ref: Mark transaction as failed on error

Author: HazAT

packages/apm/src/integrations/tracing.ts

@@ -202,16 +202,23 @@ export class Tracing implements Integration {
         return event;
       }
 
-      if (
-        Tracing.options.maxTransactionDuration !== 0 &&
-        Tracing._isEnabled() &&
-        event.type === 'transaction' &&
-        event.timestamp &&
-        event.start_timestamp &&
-        (event.timestamp - event.start_timestamp > Tracing.options.maxTransactionDuration ||
-          event.timestamp - event.start_timestamp < 0)
-      ) {
-        return null;
+      if (Tracing._isEnabled()) {
+        if (
+          Tracing.options.maxTransactionDuration !== 0 &&
+          event.type === 'transaction' &&
+          event.timestamp &&
+          event.start_timestamp &&
+          (event.timestamp - event.start_timestamp > Tracing.options.maxTransactionDuration ||
+            event.timestamp - event.start_timestamp < 0)
+        ) {
+          return null;
+        }
+
+        // TODO: Once we have session this should change
+        // If an event is level fatal we consider the transaction failed
+        if (event.type !== 'transaction' && event.level === 'fatal') {
+          Tracing.setTransactionStatus(SpanStatus.InternalError);
+        }
       }
 
       return event;

packages/types/src/span.ts

@@ -91,7 +91,7 @@ export enum SpanStatus {
   /** The operation completed successfully. */
   Ok = 'ok',
   /** Deadline expired before operation could complete. */
-  DealineExceeded = 'deadline_exceeded',
+  DeadlineExceeded = 'deadline_exceeded',
   /** 401 Unauthorized (actually does mean unauthenticated according to RFC 7235) */
   Unauthenticated = 'unauthenticated',
   /** 403 Forbidden */
@@ -164,7 +164,7 @@ export namespace SpanStatus {
         case 503:
           return SpanStatus.Unavailable;
         case 504:
-          return SpanStatus.DealineExceeded;
+          return SpanStatus.DeadlineExceeded;
         default:
           return SpanStatus.InternalError;
       }