Skip to content

Commit 11f0a75

Browse files
committed
feat(v8): Remove name
1 parent 8d2d6ff commit 11f0a75

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

packages/types/src/span.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ export interface SpanContextData {
100100
/** Interface holding all properties that can be set on a Span on creation. */
101101
export interface SpanContext {
102102
/**
103-
* Human-readable identifier for the span. Alias for span.description.
103+
* Human-readable identifier for the span.
104104
*/
105105
name?: string | undefined;
106106

@@ -174,7 +174,7 @@ export interface SpanContext {
174174
}
175175

176176
/** Span holding trace_id, span_id */
177-
export interface Span extends Omit<SpanContext, 'op' | 'status' | 'origin'> {
177+
export interface Span extends Omit<SpanContext, 'name' | 'op' | 'status' | 'origin'> {
178178
/**
179179
* Operation of the Span.
180180
*

packages/types/src/transaction.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,7 @@ export type TraceparentData = Pick<TransactionContext, 'traceId' | 'parentSpanId
4343
/**
4444
* Transaction "Class", inherits Span only has `setName`
4545
*/
46-
export interface Transaction extends TransactionContext, Omit<Span, 'setName' | 'name'> {
47-
/**
48-
* Human-readable identifier for the transaction.
49-
* @deprecated Use `spanToJSON(span).description` instead.
50-
*/
51-
name: string;
52-
46+
export interface Transaction extends Omit<TransactionContext, 'name'>, Span {
5347
/**
5448
* The ID of the transaction.
5549
* @deprecated Use `spanContext().spanId` instead.

0 commit comments

Comments
 (0)