feat(node): Check for invalid url in node transport (#6623)

Co-authored-by: Luca Forstner <[email protected]>

Author: Naddiseo

packages/node/src/transports/http.ts

@@ -47,7 +47,18 @@ function streamFromBody(body: Uint8Array | string): Readable {
  * Creates a Transport that uses native the native 'http' and 'https' modules to send events to Sentry.
  */
 export function makeNodeTransport(options: NodeTransportOptions): Transport {
-  const urlSegments = new URL(options.url);
+  let urlSegments: URL;
+
+  try {
+    urlSegments = new URL(options.url);
+  } catch (e) {
+    // eslint-disable-next-line no-console
+    console.warn(
+      '[@sentry/node]: Invalid dsn or tunnel option, will not send any events. The tunnel option must be a full URL when used.',
+    );
+    return createTransport(options, () => Promise.resolve({}));
+  }
+
   const isHttps = urlSegments.protocol === 'https:';
 
   // Proxy prioritization: http => `options.proxy` | `process.env.http_proxy`

packages/node/test/transports/http.test.ts

@@ -399,4 +399,20 @@ describe('makeNewHttpTransport()', () => {
       );
     });
   });
+
+  it('should create a noop transport if an invalid url is passed', async () => {
+    const requestSpy = jest.spyOn(http, 'request');
+    const transport = makeNodeTransport({ ...defaultOptions, url: 'foo' });
+    await transport.send(EVENT_ENVELOPE);
+    expect(requestSpy).not.toHaveBeenCalled();
+  });
+
+  it('should warn if an invalid url is passed', async () => {
+    const consoleWarnSpy = jest.spyOn(console, 'warn');
+    const transport = makeNodeTransport({ ...defaultOptions, url: 'invalid url' });
+    await transport.send(EVENT_ENVELOPE);
+    expect(consoleWarnSpy).toHaveBeenCalledWith(
+      '[@sentry/node]: Invalid dsn or tunnel option, will not send any events. The tunnel option must be a full URL when used.',
+    );
+  });
 });