chore(various): Small fixes (#3368)

Author: lobsterkatie

packages/core/test/lib/request.test.ts

@@ -82,7 +82,7 @@ describe('eventToSentryRequest', () => {
       };
     });
 
-    it('ads correct type, url, and event data', () => {
+    it('adds correct type, url, and event data', () => {
       const result = eventToSentryRequest(transactionEvent, api);
       const envelope = parseEnvelopeRequest(result);
 

packages/ember/addon/instance-initializers/sentry-performance.ts

@@ -24,7 +24,7 @@ export function initialize(appInstance: ApplicationInstance): void {
   }
 }
 
-function getTransitionInformation(transition: any, router: any) {
+function getTransitionInformation(transition: any, router: any): { [key: string]: any } {
   const fromRoute = transition?.from?.name;
   const toRoute = transition && transition.to ? transition.to.name : router.currentRouteName;
   return {

packages/tracing/src/span.ts

@@ -126,7 +126,7 @@ export class Span implements SpanInterface {
     if (spanContext.parentSpanId) {
       this.parentSpanId = spanContext.parentSpanId;
     }
-    // We want to include booleans as well here
+    // check this way instad of the normal way to make sure we don't miss cases where sampled = false
     if ('sampled' in spanContext) {
       this.sampled = spanContext.sampled;
     }

packages/tracing/src/transaction.ts

@@ -40,7 +40,8 @@ export class Transaction extends SpanClass implements TransactionInterface {
     this._trimEnd = transactionContext.trimEnd;
     this._hub = hub || getCurrentHub();
 
-    // this is because transactions are also spans, and spans have a transaction pointer
+    // this is because transactions are also spans, and spans have a transaction pointer (it doesn't get set in `super`
+    // because theoretically you can create a span without a transaction, though it does you no good)
     this.transaction = this;
   }
 

packages/utils/src/string.ts

@@ -143,7 +143,7 @@ export function unicodeToBase64(plaintext: string): string {
       return bytes.toString('base64');
     }
   } catch (err) {
-    throw new SentryError(`${errMsg} Got error: ${err}`);
+    throw new SentryError(`${errMsg}\nGot error: ${err}`);
   }
 
   // we shouldn't ever get here, because one of `btoa` and `Buffer` should exist, but just in case...
@@ -189,7 +189,7 @@ export function base64ToUnicode(base64String: string): string {
       return bytes.toString('utf-8');
     }
   } catch (err) {
-    throw new SentryError(`${errMsg} Got error: ${err}`);
+    throw new SentryError(`${errMsg}\nGot error: ${err}`);
   }
 
   // we shouldn't ever get here, because one of `atob` and `Buffer` should exist, but just in case...