feat(v8): Bump minimum Node Version to 14 (#10527)

AbhiPrasad · web-flow · commit 09e8dd8048e2 · 2024-02-07T08:46:54.000-05:00
ref #9827 Drops support for node 8, 10, 12. Does not change Next.js tests, as we can look at that in #9838
diff --git a/.github/ISSUE_TEMPLATE/flaky.yml b/.github/ISSUE_TEMPLATE/flaky.yml
@@ -18,7 +18,7 @@ body:
     id: job-name
     attributes:
       label: Name of Job
-      placeholder: Build & Test / Nextjs (Node 10) Tests
+      placeholder: Build & Test / Nextjs (Node 14) Tests
       description: name of job as reported in the status report
     validations:
       required: true
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -523,7 +523,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [8, 10, 12, 14, 16, 18, 20, 21]
+        node: [14, 16, 18, 20, 21]
     steps:
       - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
         uses: actions/checkout@v4
@@ -540,9 +540,7 @@ jobs:
       - name: Run tests
         env:
           NODE_VERSION: ${{ matrix.node }}
-        run: |
-          [[ $NODE_VERSION == 8 ]] && yarn add --dev --ignore-engines --ignore-scripts --ignore-workspace-root-check ts-node@8.10.2
-          yarn test-ci-node
+        run: yarn test-ci-node
       - name: Compute test coverage
         uses: codecov/codecov-action@v4
         with:
@@ -874,7 +872,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [10, 12, 14, 16, 18, 20, 21]
+        node: [14, 16, 18, 20, 21]
         typescript:
           - false
         include:
diff --git a/dev-packages/node-integration-tests/suites/express/tracing-experimental/test.ts b/dev-packages/node-integration-tests/suites/express/tracing-experimental/test.ts
@@ -1,7 +1,6 @@
-import { conditionalTest } from '../../../utils';
 import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
 
-conditionalTest({ min: 14 })('express tracing experimental', () => {
+describe('express tracing experimental', () => {
   afterAll(() => {
     cleanupChildProcesses();
   });
diff --git a/dev-packages/node-integration-tests/suites/tracing-experimental/apollo-graphql/test.ts b/dev-packages/node-integration-tests/suites/tracing-experimental/apollo-graphql/test.ts
@@ -1,7 +1,6 @@
-import { conditionalTest } from '../../../utils';
 import { createRunner } from '../../../utils/runner';
 
-conditionalTest({ min: 14 })('GraphQL/Apollo Tests', () => {
+describe('GraphQL/Apollo Tests', () => {
   test('CJS - should instrument GraphQL queries used from Apollo Server.', done => {
     const EXPECTED_TRANSACTION = {
       transaction: 'Test Transaction',
diff --git a/dev-packages/node-integration-tests/suites/tracing-experimental/hapi/test.ts b/dev-packages/node-integration-tests/suites/tracing-experimental/hapi/test.ts
@@ -1,9 +1,8 @@
-import { conditionalTest } from '../../../utils';
 import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
 
 jest.setTimeout(20000);
 
-conditionalTest({ min: 14 })('hapi auto-instrumentation', () => {
+describe('hapi auto-instrumentation', () => {
   afterAll(async () => {
     cleanupChildProcesses();
   });
diff --git a/dev-packages/node-integration-tests/suites/tracing-experimental/mongodb/test.ts b/dev-packages/node-integration-tests/suites/tracing-experimental/mongodb/test.ts
@@ -1,11 +1,10 @@
 import { MongoMemoryServer } from 'mongodb-memory-server-global';
 
-import { conditionalTest } from '../../../utils';
 import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
 
 jest.setTimeout(20000);
 
-conditionalTest({ min: 14 })('MongoDB experimental Test', () => {
+describe('MongoDB experimental Test', () => {
   let mongoServer: MongoMemoryServer;
 
   beforeAll(async () => {
diff --git a/dev-packages/node-integration-tests/suites/tracing-experimental/mongoose/test.ts b/dev-packages/node-integration-tests/suites/tracing-experimental/mongoose/test.ts
@@ -1,11 +1,10 @@
 import { MongoMemoryServer } from 'mongodb-memory-server-global';
 
-import { conditionalTest } from '../../../utils';
 import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
 
 jest.setTimeout(20000);
 
-conditionalTest({ min: 14 })('Mongoose experimental Test', () => {
+describe('Mongoose experimental Test', () => {
   let mongoServer: MongoMemoryServer;
 
   beforeAll(async () => {
diff --git a/dev-packages/node-integration-tests/suites/tracing-experimental/mysql/test.ts b/dev-packages/node-integration-tests/suites/tracing-experimental/mysql/test.ts
@@ -1,7 +1,6 @@
-import { conditionalTest } from '../../../utils';
 import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
 
-conditionalTest({ min: 14 })('mysql auto instrumentation', () => {
+describe('mysql auto instrumentation', () => {
   afterAll(() => {
     cleanupChildProcesses();
   });
diff --git a/dev-packages/node-integration-tests/suites/tracing-experimental/mysql2/test.ts b/dev-packages/node-integration-tests/suites/tracing-experimental/mysql2/test.ts
@@ -1,7 +1,6 @@
-import { conditionalTest } from '../../../utils';
 import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
 
-conditionalTest({ min: 14 })('mysql2 auto instrumentation', () => {
+describe('mysql2 auto instrumentation', () => {
   afterAll(() => {
     cleanupChildProcesses();
   });
diff --git a/dev-packages/node-integration-tests/suites/tracing-experimental/postgres/test.ts b/dev-packages/node-integration-tests/suites/tracing-experimental/postgres/test.ts
@@ -1,7 +1,6 @@
-import { conditionalTest } from '../../../utils';
 import { createRunner } from '../../../utils/runner';
 
-conditionalTest({ min: 14 })('postgres auto instrumentation', () => {
+describe('postgres auto instrumentation', () => {
   test('should auto-instrument `pg` package', done => {
     const EXPECTED_TRANSACTION = {
       transaction: 'Test Transaction',
diff --git a/dev-packages/node-integration-tests/suites/tracing-new/apollo-graphql/test.ts b/dev-packages/node-integration-tests/suites/tracing-new/apollo-graphql/test.ts
@@ -1,8 +1,6 @@
-import { TestEnv, assertSentryTransaction, conditionalTest } from '../../../utils';
+import { TestEnv, assertSentryTransaction } from '../../../utils';
 
-// Node 10 is not supported by `graphql-js`
-// Ref: https://github.com/graphql/graphql-js/blob/main/package.json
-conditionalTest({ min: 12 })('GraphQL/Apollo Tests', () => {
+describe('GraphQL/Apollo Tests', () => {
   test('should instrument GraphQL and Apollo Server.', async () => {
     const env = await TestEnv.init(__dirname);
     const envelope = await env.getEnvelopeRequest({ envelopeType: 'transaction' });
diff --git a/dev-packages/node-integration-tests/suites/tracing-new/auto-instrument/mongodb/test.ts b/dev-packages/node-integration-tests/suites/tracing-new/auto-instrument/mongodb/test.ts
@@ -1,11 +1,11 @@
 import { MongoMemoryServer } from 'mongodb-memory-server-global';
 
-import { TestEnv, assertSentryTransaction, conditionalTest } from '../../../../utils';
+import { TestEnv, assertSentryTransaction } from '../../../../utils';
 
 // This test can take longer.
 jest.setTimeout(15000);
 
-conditionalTest({ min: 12 })('MongoDB Test', () => {
+describe('MongoDB Test', () => {
   let mongoServer: MongoMemoryServer;
 
   beforeAll(async () => {
diff --git a/dev-packages/node-integration-tests/suites/tracing-new/prisma-orm/test.ts b/dev-packages/node-integration-tests/suites/tracing-new/prisma-orm/test.ts
@@ -1,6 +1,6 @@
-import { TestEnv, assertSentryTransaction, conditionalTest } from '../../../utils';
+import { TestEnv, assertSentryTransaction } from '../../../utils';
 
-conditionalTest({ min: 12 })('Prisma ORM Integration', () => {
+describe('Prisma ORM Integration', () => {
   test('should instrument Prisma client for tracing.', async () => {
     const env = await TestEnv.init(__dirname);
     const envelope = await env.getEnvelopeRequest({ envelopeType: 'transaction' });
diff --git a/dev-packages/node-integration-tests/suites/tracing/apollo-graphql/test.ts b/dev-packages/node-integration-tests/suites/tracing/apollo-graphql/test.ts
@@ -1,8 +1,6 @@
-import { TestEnv, assertSentryTransaction, conditionalTest } from '../../../utils';
+import { TestEnv, assertSentryTransaction } from '../../../utils';
 
-// Node 10 is not supported by `graphql-js`
-// Ref: https://github.com/graphql/graphql-js/blob/main/package.json
-conditionalTest({ min: 12 })('GraphQL/Apollo Tests', () => {
+describe('GraphQL/Apollo Tests', () => {
   test('should instrument GraphQL and Apollo Server.', async () => {
     const env = await TestEnv.init(__dirname);
     const envelope = await env.getEnvelopeRequest({ envelopeType: 'transaction' });
diff --git a/dev-packages/node-integration-tests/suites/tracing/auto-instrument/mongodb/test.ts b/dev-packages/node-integration-tests/suites/tracing/auto-instrument/mongodb/test.ts
@@ -1,11 +1,11 @@
 import { MongoMemoryServer } from 'mongodb-memory-server-global';
 
-import { TestEnv, assertSentryTransaction, conditionalTest } from '../../../../utils';
+import { TestEnv, assertSentryTransaction } from '../../../../utils';
 
 // This test can take longer.
 jest.setTimeout(15000);
 
-conditionalTest({ min: 12 })('MongoDB Test', () => {
+describe('MongoDB Test', () => {
   let mongoServer: MongoMemoryServer;
 
   beforeAll(async () => {
diff --git a/dev-packages/node-integration-tests/suites/tracing/prisma-orm/test.ts b/dev-packages/node-integration-tests/suites/tracing/prisma-orm/test.ts
@@ -1,6 +1,6 @@
-import { TestEnv, assertSentryTransaction, conditionalTest } from '../../../utils';
+import { TestEnv, assertSentryTransaction } from '../../../utils';
 
-conditionalTest({ min: 12 })('Prisma ORM Integration', () => {
+describe('Prisma ORM Integration', () => {
   test('should instrument Prisma client for tracing.', async () => {
     const env = await TestEnv.init(__dirname);
     const envelope = await env.getEnvelopeRequest({ envelopeType: 'transaction' });
diff --git a/packages/angular/package.json b/packages/angular/package.json
@@ -7,7 +7,7 @@
   "author": "Sentry",
   "license": "MIT",
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "main": "build/bundles/sentry-angular.umd.js",
   "module": "build/fesm2015/sentry-angular.js",
diff --git a/packages/browser/package.json b/packages/browser/package.json
@@ -7,7 +7,7 @@
   "author": "Sentry",
   "license": "MIT",
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "files": [
     "cjs",
diff --git a/packages/bun/package.json b/packages/bun/package.json
@@ -7,7 +7,7 @@
   "author": "Sentry",
   "license": "MIT",
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "files": [
     "cjs",
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -7,7 +7,7 @@
   "author": "Sentry",
   "license": "MIT",
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "files": [
     "cjs",
diff --git a/packages/eslint-config-sdk/package.json b/packages/eslint-config-sdk/package.json
@@ -12,7 +12,7 @@
     "sentry"
   ],
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "files": [
     "src"
diff --git a/packages/eslint-plugin-sdk/package.json b/packages/eslint-plugin-sdk/package.json
@@ -12,7 +12,7 @@
     "sentry"
   ],
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "files": [
     "src"
diff --git a/packages/gatsby/package.json b/packages/gatsby/package.json
@@ -11,7 +11,7 @@
     "gatsby-plugin"
   ],
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "files": [
     "cjs",
diff --git a/packages/hub/package.json b/packages/hub/package.json
@@ -7,7 +7,7 @@
   "author": "Sentry",
   "license": "MIT",
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "files": [
     "cjs",
diff --git a/packages/integrations/package.json b/packages/integrations/package.json
@@ -7,7 +7,7 @@
   "author": "Sentry",
   "license": "MIT",
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "publishConfig": {
     "access": "public"
diff --git a/packages/nextjs/package.json b/packages/nextjs/package.json
@@ -7,7 +7,7 @@
   "author": "Sentry",
   "license": "MIT",
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "main": "build/cjs/index.server.js",
   "module": "build/esm/index.server.js",
diff --git a/packages/nextjs/test/integration/test/server/doubleEndMethodOnVercel.test.ts b/packages/nextjs/test/integration/test/server/doubleEndMethodOnVercel.test.ts
@@ -4,10 +4,6 @@ import { NextTestEnv } from './utils/helpers';
 // `res.send` multiple times in one request handler.
 //  https://github.com/getsentry/sentry-javascript/issues/6670
 it.skip('should not break API routes on Vercel if people call res.json or res.send multiple times in one request handler', async () => {
-  if (process.env.NODE_MAJOR === '10') {
-    console.log('not running doubleEndMethodOnVercel test on Node 10');
-    return;
-  }
   const env = await NextTestEnv.init();
   const url = `${env.url}/api/doubleEndMethodOnVercel`;
   const response = await env.getAPIResponse(url);
diff --git a/packages/node/README.md b/packages/node/README.md
@@ -18,7 +18,7 @@
 ## Usage
 
 To use this SDK, call `init(options)` as early as possible in the main entry module. This will initialize the SDK and
-hook into the environment. Note that you can turn off almost all side effects using the respective options.
+hook into the environment. Note that you can turn off almost all side effects using the respective options. Minimum supported Node version is Node 14.
 
 ```javascript
 // CJS syntax
diff --git a/packages/node/package.json b/packages/node/package.json
@@ -7,7 +7,7 @@
   "author": "Sentry",
   "license": "MIT",
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "files": [
     "cjs",
diff --git a/packages/node/test/async/hooks.test.ts b/packages/node/test/async/hooks.test.ts
@@ -10,9 +10,8 @@ import {
 } from '@sentry/core';
 
 import { setHooksAsyncContextStrategy } from '../../src/async/hooks';
-import { conditionalTest } from '../utils';
 
-conditionalTest({ min: 12 })('setHooksAsyncContextStrategy()', () => {
+describe('setHooksAsyncContextStrategy()', () => {
   beforeEach(() => {
     const hub = new Hub();
     // eslint-disable-next-line deprecation/deprecation
diff --git a/packages/node/test/integrations/http.test.ts b/packages/node/test/integrations/http.test.ts
@@ -682,17 +682,11 @@ describe('default protocols', () => {
   it('makes https request over http proxy', async () => {
     const key = 'catcatchers';
     const p = captureBreadcrumb(key);
-    let nockProtocol = 'https';
 
     const proxy = 'http://some.url:3128';
     const agent = new HttpsProxyAgent(proxy);
 
-    // TODO (v8): No longer needed once we drop Node 8 support
-    if (NODE_VERSION.major < 9) {
-      nockProtocol = 'http';
-    }
-
-    nock(`${nockProtocol}://${key}.ingest.sentry.io`).get('/api/123122332/store/').reply(200);
+    nock(`https://${key}.ingest.sentry.io`).get('/api/123122332/store/').reply(200);
 
     https.get({
       host: `${key}.ingest.sentry.io`,
diff --git a/packages/node/test/integrations/undici.test.ts b/packages/node/test/integrations/undici.test.ts
@@ -2,7 +2,7 @@ import * as http from 'http';
 import { Transaction, getActiveSpan, getClient, getCurrentScope, setCurrentClient, startSpan } from '@sentry/core';
 import { spanToTraceHeader } from '@sentry/core';
 import { Hub, makeMain, runWithAsyncContext } from '@sentry/core';
-import type { fetch as FetchType } from 'undici';
+import { fetch } from 'undici';
 
 import { NodeClient } from '../../src/client';
 import type { Undici, UndiciOptions } from '../../src/integrations/undici';
@@ -13,17 +13,16 @@ import { conditionalTest } from '../utils';
 const SENTRY_DSN = 'https://0@0.ingest.sentry.io/0';
 
 let hub: Hub;
-let fetch: typeof FetchType;
 
 beforeAll(async () => {
   try {
     await setupTestServer();
-    // need to conditionally require `undici` because it's not available in Node 10
-    // eslint-disable-next-line @typescript-eslint/no-var-requires
-    fetch = require('undici').fetch;
   } catch (e) {
     // eslint-disable-next-line no-console
-    console.warn('Undici integration tests are skipped because undici is not installed.');
+    const error = new Error('Undici integration tests are skipped because test server could not be set up.');
+    // This needs lib es2022 and newer so marking as any
+    (error as any).cause = e;
+    throw e;
   }
 });
 
diff --git a/packages/node/test/manual/webpack-async-context/npm-build.js b/packages/node/test/manual/webpack-async-context/npm-build.js
@@ -7,11 +7,6 @@ if (Number(process.versions.node.split('.')[0]) >= 18) {
   process.exit(0);
 }
 
-// Webpack test does not work in Node 8 and below.
-if (Number(process.versions.node.split('.')[0]) <= 8) {
-  process.exit(0);
-}
-
 // biome-ignore format: Follow-up for prettier
 webpack(
   {
diff --git a/packages/opentelemetry-node/package.json b/packages/opentelemetry-node/package.json
@@ -7,7 +7,7 @@
   "author": "Sentry",
   "license": "MIT",
   "engines": {
-    "node": ">=8"
+    "node": ">=14"
   },
   "files": [
     "cjs",
diff --git a/packages/profiling-node/package.json b/packages/profiling-node/package.json
@@ -19,7 +19,7 @@
     "sentry-prune-profiler-binaries": "scripts/prune-profiler-binaries.js"
   },
   "engines": {
-    "node": ">=8.0.0"
+    "node": ">=14"
   },
   "publishConfig": {
     "access": "public"
diff --git a/packages/react/package.json b/packages/react/package.json
diff --git a/packages/replay-canvas/README.md b/packages/replay-canvas/README.md
diff --git a/packages/replay/README.md b/packages/replay/README.md
diff --git a/packages/svelte/package.json b/packages/svelte/package.json
diff --git a/packages/tracing-internal/package.json b/packages/tracing-internal/package.json
diff --git a/packages/tracing-internal/test/browser/backgroundtab.test.ts b/packages/tracing-internal/test/browser/backgroundtab.test.ts
diff --git a/packages/tracing-internal/test/browser/browsertracing.test.ts b/packages/tracing-internal/test/browser/browsertracing.test.ts
diff --git a/packages/tracing/package.json b/packages/tracing/package.json
diff --git a/packages/types/package.json b/packages/types/package.json
diff --git a/packages/utils/package.json b/packages/utils/package.json
diff --git a/packages/utils/src/requestdata.ts b/packages/utils/src/requestdata.ts
diff --git a/packages/utils/src/vendor/escapeStringForRegex.ts b/packages/utils/src/vendor/escapeStringForRegex.ts
diff --git a/packages/utils/test/normalize.test.ts b/packages/utils/test/normalize.test.ts
diff --git a/packages/vercel-edge/package.json b/packages/vercel-edge/package.json
diff --git a/packages/vue/package.json b/packages/vue/package.json
diff --git a/packages/wasm/package.json b/packages/wasm/package.json
diff --git a/scripts/node-unit-tests.ts b/scripts/node-unit-tests.ts
