Skip to content

Commit 04a8f62

Browse files
committed
apply suggestions fromcode review
1 parent dd4971f commit 04a8f62

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

dev-packages/e2e-tests/test-applications/aws-lambda-layer-esm/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "node-express-app",
2+
"name": "aws-lambda-layer-esm",
33
"version": "1.0.0",
44
"private": true,
55
"scripts": {
@@ -10,6 +10,7 @@
1010
"test:assert": "pnpm test"
1111
},
1212
"dependencies": {
13+
"//": "Linked to the local Lambda layer build",
1314
"@sentry/aws-serverless": "link:../../../../packages/aws-serverless/build/aws/dist-serverless/nodejs/node_modules/@sentry/aws-serverless"
1415
},
1516
"devDependencies": {

dev-packages/e2e-tests/test-applications/aws-lambda-layer-esm/start-event-proxy.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ import { startEventProxyServer } from '@sentry-internal/test-utils';
22

33
startEventProxyServer({
44
port: 3031,
5-
proxyServerName: 'aws-serverless-lambda-layer-esm',
5+
proxyServerName: 'aws-lambda-layer-esm',
66
});

dev-packages/e2e-tests/test-applications/aws-lambda-layer-esm/tests/basic.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { expect, test } from '@playwright/test';
33
import { waitForTransaction } from '@sentry-internal/test-utils';
44

55
test('Lambda layer SDK bundle sends events', async ({ request }) => {
6-
const transactionEventPromise = waitForTransaction('aws-serverless-lambda-layer-esm', transactionEvent => {
6+
const transactionEventPromise = waitForTransaction('aws-lambda-layer-esm', transactionEvent => {
77
return transactionEvent?.transaction === 'my-lambda';
88
});
99

packages/aws-serverless/scripts/buildLambdaLayer.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,16 @@ function run(cmd: string, options?: childProcess.ExecSyncOptions): string {
1717
* Build the AWS lambda layer by first installing the local package into `build/aws/dist-serverless/nodejs`.
1818
* Then, prune the node_modules directory to remove unused files by first getting all necessary files with
1919
* `@vercel/nft` and then deleting all other files inside `node_modules`.
20-
* Finally, minify the files and create a zip file of the layer.
20+
* Finally, create a zip file of the layer.
2121
*/
2222
async function buildLambdaLayer(): Promise<void> {
23+
console.log('Building Lambda layer.');
2324
console.log('Installing local @sentry/aws-serverless into build/aws/dist-serverless/nodejs.');
2425
run('npm install . --prefix ./build/aws/dist-serverless/nodejs --install-links --silent');
2526

2627
await pruneNodeModules();
27-
fs.unlinkSync('./build/aws/dist-serverless/nodejs/package.json');
28-
fs.unlinkSync('./build/aws/dist-serverless/nodejs/package-lock.json');
28+
fs.rmSync('./build/aws/dist-serverless/nodejs/package.json', { force: true });
29+
fs.rmSync('./build/aws/dist-serverless/nodejs/package-lock.json', { force: true });
2930

3031
// The layer also includes `awslambda-auto.js`, a helper file which calls `Sentry.init()` and wraps the lambda
3132
// handler. It gets run when Node is launched inside the lambda, using the environment variable
@@ -107,7 +108,7 @@ function removeEmptyDirs(dir: string): void {
107108
if (remainingEntries.length === 0) {
108109
fs.rmdirSync(dir);
109110
}
110-
} catch (error) {
111+
} catch {
111112
// Directory might not exist or might not be empty, that's ok
112113
}
113114
}

0 commit comments

Comments
 (0)