PR feedback

Author: mydea

packages/core/src/baseclient.ts

@@ -366,7 +366,7 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
   public on(hook: 'beforeEnvelope', callback: (envelope: Envelope) => void): void;
 
   /** @inheritdoc */
-  public on(hook: 'beforeBreadcrumb', callback: (breadcrumb: Breadcrumb, hint?: BreadcrumbHint) => void): void;
+  public on(hook: 'beforeAddBreadcrumb', callback: (breadcrumb: Breadcrumb, hint?: BreadcrumbHint) => void): void;
 
   /** @inheritdoc */
   public on(hook: string, callback: unknown): void {
@@ -385,7 +385,7 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
   public emit(hook: 'beforeEnvelope', envelope: Envelope): void;
 
   /** @inheritdoc */
-  public emit(hook: 'beforeBreadcrumb', breadcrumb: Breadcrumb, hint?: BreadcrumbHint): void;
+  public emit(hook: 'beforeAddBreadcrumb', breadcrumb: Breadcrumb, hint?: BreadcrumbHint): void;
 
   /** @inheritdoc */
   public emit(hook: string, ...rest: unknown[]): void {

packages/core/src/hub.ts

@@ -272,7 +272,7 @@ export class Hub implements HubInterface {
     if (finalBreadcrumb === null) return;
 
     if (client.emit) {
-      client.emit('beforeBreadcrumb', finalBreadcrumb, hint);
+      client.emit('beforeAddBreadcrumb', finalBreadcrumb, hint);
     }
 
     scope.addBreadcrumb(finalBreadcrumb, maxBreadcrumbs);

packages/integrations/src/extendednetworkbreadcrumbs.ts

@@ -63,7 +63,7 @@ export class ExtendedNetworkBreadcrumbs implements Integration {
     const options = this._options as ExtendedNetworkBreadcrumbsOptions;
 
     if (client && client.on) {
-      client.on('beforeBreadcrumb', (breadcrumb, hint) => _beforeNetworkBreadcrumb(options, breadcrumb, hint));
+      client.on('beforeAddBreadcrumb', (breadcrumb, hint) => _beforeNetworkBreadcrumb(options, breadcrumb, hint));
     }
   }
 }

packages/types/src/client.ts

@@ -167,7 +167,7 @@ export interface Client<O extends ClientOptions = ClientOptions> {
   /**
    * Register a callback before a breadcrumb is added.
    */
-  on?(hook: 'beforeBreadcrumb', callback: (breadcrumb: Breadcrumb, hint?: BreadcrumbHint) => void): void;
+  on?(hook: 'beforeAddBreadcrumb', callback: (breadcrumb: Breadcrumb, hint?: BreadcrumbHint) => void): void;
 
   /**
    * Fire a hook event for transaction start and finish. Expects to be given a transaction as the
@@ -184,5 +184,5 @@ export interface Client<O extends ClientOptions = ClientOptions> {
   /**
    * Fire a hook for when a bredacrumb is added. Expects the breadcrumb as second argument.
    */
-  emit?(hook: 'beforeBreadcrumb', breadcrumb: Breadcrumb, hint?: BreadcrumbHint): void;
+  emit?(hook: 'beforeAddBreadcrumb', breadcrumb: Breadcrumb, hint?: BreadcrumbHint): void;
 }