ref(replay): Send SDK version in Replay events

Author: Lms24

packages/replay/jest.setup.ts

@@ -1,13 +1,10 @@
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */
 import { getCurrentHub } from '@sentry/core';
 import type { ReplayRecordingData, Transport } from '@sentry/types';
-import {TextEncoder} from 'util';
+import { TextEncoder } from 'util';
 
 import type { ReplayContainer, Session } from './src/types';
 
-// @ts-ignore TS error, this is replaced in prod builds bc of rollup
-global.__SENTRY_REPLAY_VERSION__ = 'version:Test';
-
 (global as any).TextEncoder = TextEncoder;
 
 type MockTransport = jest.MockedFunction<Transport['send']>;

packages/replay/rollup.bundle.config.js

@@ -1,25 +1,11 @@
-import replace from '@rollup/plugin-replace';
-
 import { makeBaseBundleConfig, makeBundleConfigVariants } from '../../rollup/index.js';
 
-import pkg from './package.json';
-
 const baseBundleConfig = makeBaseBundleConfig({
   bundleType: 'addon',
   entrypoints: ['src/index.ts'],
   jsVersion: 'es6',
   licenseTitle: '@sentry/replay',
   outputFileBase: () => 'bundles/replay',
-  packageSpecificConfig: {
-    plugins: [
-      replace({
-        preventAssignment: true,
-        values: {
-          __SENTRY_REPLAY_VERSION__: JSON.stringify(pkg.version),
-        },
-      }),
-    ],
-  },
 });
 
 const builds = makeBundleConfigVariants(baseBundleConfig);

packages/replay/rollup.npm.config.js

@@ -1,24 +1,11 @@
 import path from 'path';
 
-import replace from '@rollup/plugin-replace';
-
 import { makeBaseNPMConfig, makeNPMConfigVariants } from '../../rollup/index';
 
-import pkg from './package.json';
-
 export default makeNPMConfigVariants(
   makeBaseNPMConfig({
     hasBundles: true,
     packageSpecificConfig: {
-      plugins: [
-        // TODO: Remove this - replay version will be in sync w/ SDK version
-        replace({
-          preventAssignment: true,
-          values: {
-            __SENTRY_REPLAY_VERSION__: JSON.stringify(pkg.version),
-          },
-        }),
-      ],
       output: {
         // set exports to 'named' or 'auto' so that rollup doesn't warn about
         // the default export in `worker/worker.js`

packages/replay/src/types.ts

@@ -29,10 +29,6 @@ export interface WorkerRequest {
   args: unknown[];
 }
 
-declare global {
-  const __SENTRY_REPLAY_VERSION__: string;
-}
-
 // PerformancePaintTiming and PerformanceNavigationTiming are only available with TS 4.4 and newer
 // Therefore, we're exporting them here to make them available in older TS versions
 export type PerformancePaintTiming = PerformanceEntry;

packages/replay/src/util/prepareReplayEvent.ts

@@ -30,12 +30,12 @@ export async function prepareReplayEvent({
 
   // extract the SDK name because `client._prepareEvent` doesn't add it to the event
   const metadata = client.getSdkMetadata && client.getSdkMetadata();
-  const name = (metadata && metadata.sdk && metadata.sdk.name) || 'sentry.javascript.unknown';
+  const { name, version } = (metadata && metadata.sdk) || {};
 
   preparedEvent.sdk = {
     ...preparedEvent.sdk,
-    version: __SENTRY_REPLAY_VERSION__,
-    name,
+    name: name || 'sentry.javascript.unknown',
+    version: version || '0.0.0',
   };
 
   return preparedEvent;