Skip to content

Commit 003d519

Browse files
committed
pass entire options object when reformatting include option
1 parent bd197bf commit 003d519

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

packages/node/src/integrations/requestdata.ts

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ export class RequestData implements Integration {
104104
// the moment it lives here, though, until https://github.com/getsentry/sentry-javascript/issues/5718 is addressed.
105105
// (TL;DR: Those functions touch many parts of the repo in many different ways, and need to be clened up. Once
106106
// that's happened, it will be easier to add this logic in without worrying about unexpected side effects.)
107-
const { include, addRequestData, transactionNamingScheme } = this._options;
107+
const { addRequestData, transactionNamingScheme } = this._options;
108108

109109
addGlobalEventProcessor(event => {
110110
const hub = getCurrentHub();
@@ -117,7 +117,7 @@ export class RequestData implements Integration {
117117
return event;
118118
}
119119

120-
const processedEvent = addRequestData(event, req, { include: formatIncludeOption(include) });
120+
const processedEvent = addRequestData(event, req, convertReqDataIntegrationOptsToAddReqDataOpts(this._options));
121121

122122
// Transaction events already have the right `transaction` value
123123
if (event.type === 'transaction' || transactionNamingScheme === 'handler') {
@@ -151,12 +151,12 @@ export class RequestData implements Integration {
151151
}
152152
}
153153

154-
/** Convert `include` option to match what `addRequestDataToEvent` expects */
154+
/** Convert this integration's options to match what `addRequestDataToEvent` expects */
155155
/** TODO: Can possibly be deleted once https://github.com/getsentry/sentry-javascript/issues/5718 is fixed */
156-
function formatIncludeOption(
157-
integrationInclude: RequestDataIntegrationOptions['include'] = {},
158-
): AddRequestDataToEventOptions['include'] {
159-
const { ip, user, ...requestOptions } = integrationInclude;
156+
function convertReqDataIntegrationOptsToAddReqDataOpts(
157+
integrationOptions: RequestDataIntegrationOptions,
158+
): AddRequestDataToEventOptions {
159+
const { ip, user, ...requestOptions } = integrationOptions.include;
160160

161161
const requestIncludeKeys: string[] = [];
162162
for (const [key, value] of Object.entries(requestOptions)) {
@@ -181,9 +181,11 @@ function formatIncludeOption(
181181
}
182182

183183
return {
184-
ip,
185-
user: addReqDataUserOpt,
186-
request: requestIncludeKeys.length !== 0 ? requestIncludeKeys : undefined,
184+
include: {
185+
ip,
186+
user: addReqDataUserOpt,
187+
request: requestIncludeKeys.length !== 0 ? requestIncludeKeys : undefined,
188+
},
187189
};
188190
}
189191

0 commit comments

Comments
 (0)