-
-
Notifications
You must be signed in to change notification settings - Fork 461
Make user segment a top level property #2257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Make user segment a top level property ([#2257](https://github.com/getsentry/sentry-java/pull/2257))If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d89dea | 345.59 ms | 364.06 ms | 18.47 ms |
| 1e4690d | 354.69 ms | 387.88 ms | 33.19 ms |
| 3d89dea | 322.38 ms | 350.82 ms | 28.45 ms |
| 2f079a1 | 296.91 ms | 337.43 ms | 40.51 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d89dea | 1.74 MiB | 2.33 MiB | 604.92 KiB |
| 1e4690d | 1.74 MiB | 2.33 MiB | 604.92 KiB |
| 3d89dea | 1.74 MiB | 2.33 MiB | 604.92 KiB |
| 2f079a1 | 1.74 MiB | 2.33 MiB | 605.56 KiB |
Previous results on branch: feat/make-user-segment-top-level-property
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 889d1d9 | 322.02 ms | 341.21 ms | 19.19 ms |
| c7dc7e4 | 357.37 ms | 402.27 ms | 44.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 889d1d9 | 1.74 MiB | 2.33 MiB | 605.65 KiB |
| c7dc7e4 | 1.74 MiB | 2.33 MiB | 605.55 KiB |
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
The class |
Created #2259 to track and do separately. |
📜 Description
User segment is now a top level property.
💡 Motivation and Context
Closes #2240
💚 How did you test it?
📝 Checklist
🔮 Next steps