Merge 2f02001 into f0af5c3

Author: adinauer

build.gradle.kts

@@ -99,7 +99,7 @@ allprojects {
             dependsOn("cleanTest")
         }
         withType<JavaCompile> {
-            options.compilerArgs.addAll(arrayOf("-Xlint:all", "-Werror", "-Xlint:-classfile", "-Xlint:-processing"))
+            options.compilerArgs.addAll(arrayOf("-Xlint:all", "-Werror", "-Xlint:-classfile", "-Xlint:-processing", "-Xlint:-try"))
         }
     }
 }

sentry/api/sentry.api

@@ -663,6 +663,7 @@ public void setUnknown(@Nullable Map<String, Object> unknown) {
   @Override
   @SuppressWarnings("JavaUtilDate")
   public int compareTo(@NotNull Breadcrumb o) {
+    // TODO also use nano time if equal
     return timestamp.compareTo(o.timestamp);
   }
 

sentry/src/main/java/io/sentry/Breadcrumb.java

@@ -237,6 +237,7 @@ public void setTag(@NotNull String key, @NotNull String value) {
 
   @Override
   public void removeTag(@NotNull String key) {
+    // TODO should this go to all scopes?
     getDefaultWriteScope().removeTag(key);
   }
 
@@ -256,6 +257,7 @@ public void setExtra(@NotNull String key, @NotNull String value) {
 
   @Override
   public void removeExtra(@NotNull String key) {
+    // TODO should this go to all scopes?
     getDefaultWriteScope().removeExtra(key);
   }
 
@@ -305,10 +307,12 @@ public void setContexts(@NotNull String key, @NotNull Character value) {
 
   @Override
   public void removeContexts(@NotNull String key) {
+    // TODO should this go to all scopes?
     getDefaultWriteScope().removeContexts(key);
   }
 
   private @NotNull IScope getDefaultWriteScope() {
+    // TODO use Scopes.getSpecificScope?
     if (ScopeType.CURRENT.equals(getOptions().getDefaultScopeType())) {
       return scope;
     }

sentry/src/main/java/io/sentry/CombinedScopeView.java

@@ -3,5 +3,8 @@
 public enum ScopeType {
   CURRENT,
   ISOLATION,
-  GLOBAL;
+  GLOBAL,
+
+  // TODO do we need a combined as well so configureScope
+  COMBINED;
 }

sentry/src/main/java/io/sentry/ScopeType.java

@@ -363,6 +363,7 @@ public void endSession() {
   }
 
   private IScope getCombinedScopeView() {
+    // TODO create in ctor?
     return new CombinedScopeView(getGlobalScope(), isolationScope, scope);
   }
 
@@ -428,6 +429,7 @@ public void addBreadcrumb(final @NotNull Breadcrumb breadcrumb, final @Nullable
   }
 
   private IScope getSpecificScope(final @Nullable ScopeType scopeType) {
+    // TODO extract and reuse
     if (scopeType != null) {
       switch (scopeType) {
         case CURRENT: