Skip to content

Commit ce1f729

Browse files
committed
Keep OTel and Sentry span name/op in sync
1 parent 0d84b57 commit ce1f729

File tree

3 files changed

+19
-1
lines changed

3 files changed

+19
-1
lines changed

sentry-opentelemetry/sentry-opentelemetry-bootstrap/api/sentry-opentelemetry-bootstrap.api

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@ public final class io/sentry/opentelemetry/OtelContextScopesStorage : io/sentry/
1919

2020
public final class io/sentry/opentelemetry/OtelSpanContext : io/sentry/SpanContext {
2121
public fun <init> (Lio/opentelemetry/sdk/trace/ReadWriteSpan;Lio/sentry/TracesSamplingDecision;Lio/sentry/opentelemetry/OtelSpanWrapper;Lio/sentry/Baggage;)V
22+
public fun getOperation ()Ljava/lang/String;
2223
public fun getStatus ()Lio/sentry/SpanStatus;
24+
public fun setOperation (Ljava/lang/String;)V
2325
public fun setStatus (Lio/sentry/SpanStatus;)V
2426
}
2527

sentry-opentelemetry/sentry-opentelemetry-bootstrap/src/main/java/io/sentry/opentelemetry/OtelSpanContext.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,23 @@ public void setStatus(@Nullable SpanStatus status) {
7575
}
7676
}
7777

78+
@Override
79+
public @NotNull String getOperation() {
80+
final @Nullable ReadWriteSpan otelSpan = span.get();
81+
if (otelSpan != null) {
82+
return otelSpan.getName();
83+
}
84+
return "<unlabeled span>";
85+
}
86+
87+
@Override
88+
public void setOperation(@NotNull String operation) {
89+
final @Nullable ReadWriteSpan otelSpan = span.get();
90+
if (otelSpan != null) {
91+
otelSpan.updateName(operation);
92+
}
93+
}
94+
7895
private @Nullable SpanStatus otelStatusCodeFallback(final @NotNull StatusData otelStatus) {
7996
if (otelStatus.getStatusCode() == StatusCode.ERROR) {
8097
return SpanStatus.UNKNOWN_ERROR;

sentry/src/main/java/io/sentry/SpanContext.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@ public SpanId getParentSpanId() {
150150
}
151151

152152
public @NotNull String getOperation() {
153-
// TODO [POTEL] use span name here
154153
return op;
155154
}
156155

0 commit comments

Comments
 (0)