Skip to content

Commit cca09cf

Browse files
committed
Always use baggage header if sentr-trace is present on incoming request to make sure baggage is frozen
1 parent 06a4570 commit cca09cf

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

sentry-opentelemetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SentryPropagator.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,8 @@ public <C> Context extract(
7575
Context modifiedContext = context.with(SentryOtelKeys.SENTRY_TRACE_KEY, sentryTraceHeader);
7676

7777
final @Nullable String baggageString = getter.get(carrier, BaggageHeader.BAGGAGE_HEADER);
78-
if (baggageString != null) {
79-
Baggage baggage = Baggage.fromHeader(baggageString);
80-
modifiedContext = modifiedContext.with(SentryOtelKeys.SENTRY_BAGGAGE_KEY, baggage);
81-
}
78+
Baggage baggage = Baggage.fromHeader(baggageString);
79+
modifiedContext = modifiedContext.with(SentryOtelKeys.SENTRY_BAGGAGE_KEY, baggage);
8280

8381
Span wrappedSpan = Span.wrap(otelSpanContext);
8482
modifiedContext = modifiedContext.with(wrappedSpan);

sentry/src/main/java/io/sentry/Baggage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public final class Baggage {
3535
final @NotNull ILogger logger;
3636

3737
@NotNull
38-
public static Baggage fromHeader(final String headerValue) {
38+
public static Baggage fromHeader(final @Nullable String headerValue) {
3939
return Baggage.fromHeader(
4040
headerValue, false, HubAdapter.getInstance().getOptions().getLogger());
4141
}

0 commit comments

Comments
 (0)