Skip to content

Commit c91ac0e

Browse files
committed
Dontwarn about missing compose class as we check for it at runtime
1 parent da650a5 commit c91ac0e

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
### Fixes
1010

1111
- Use minSdk compatible `Objects` class ([#2436](https://github.com/getsentry/sentry-java/pull/2436))
12+
- Prevent R8 from warning on missing classes, as we check for their presence at runtime ([#2439](https://github.com/getsentry/sentry-java/pull/2439))
1213

1314
### Features
1415

sentry-android-core/proguard-rules.pro

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@
2020

2121
# don't warn jetbrains annotations
2222
-dontwarn org.jetbrains.annotations.**
23-
# don't warn about missing classes (mainly for Guardsquare's proguard).
24-
# We are checking for their presence at runtime
23+
# don't warn about missing classes, as we are checking for their presence at runtime
2524
-dontwarn io.sentry.android.timber.SentryTimberIntegration
2625
-dontwarn io.sentry.android.fragment.FragmentLifecycleIntegration
26+
-dontwarn io.sentry.compose.gestures.ComposeGestureTargetLocator
2727

2828
# To ensure that stack traces is unambiguous
2929
# https://developer.android.com/studio/build/shrink-code#decode-stack-trace

sentry-android-integration-tests/sentry-test-agp/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ android {
1919
isMinifyEnabled = true
2020
signingConfig = signingConfigs.getByName("debug") // to be able to run release mode
2121
proguardFiles(
22-
getDefaultProguardFile("proguard-android-optimize.txt"),
23-
"benchmark-proguard-rules.pro"
22+
getDefaultProguardFile("proguard-android-optimize.txt")
2423
)
2524
ndk {
2625
abiFilters.clear()
@@ -59,6 +58,7 @@ dependencies {
5958
implementation(projects.sentryAndroidTimber)
6059

6160
implementation(Config.Libs.fragment)
61+
implementation(Config.Libs.timber)
6262

6363
implementation(Config.Libs.retrofit2)
6464
}

0 commit comments

Comments
 (0)