Skip to content

Commit c038019

Browse files
committed
fix changelog; restore background tasks in sample
1 parent c4bcd1a commit c038019

File tree

3 files changed

+31
-31
lines changed

3 files changed

+31
-31
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010

1111
### Fixes
1212

13-
- Add `auto.graphql.graphql22` to ignored span origins when using OpenTelemetry
14-
- The Spring Boot 3 WebFlux sample now uses our GraphQL v22 integration
13+
- Add `auto.graphql.graphql22` to ignored span origins when using OpenTelemetry ([#3828](https://github.com/getsentry/sentry-java/pull/3828))
14+
- The Spring Boot 3 WebFlux sample now uses our GraphQL v22 integration ([#3828](https://github.com/getsentry/sentry-java/pull/3828))
1515

1616
### Behavioural Changes
1717

sentry-samples/sentry-samples-spring-boot-jakarta-opentelemetry/src/main/java/io/sentry/samples/spring/boot/jakarta/CustomJob.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public class CustomJob {
1717
private static final Logger LOGGER = LoggerFactory.getLogger(CustomJob.class);
1818

1919
@SentryCheckIn("monitor_slug_1")
20-
// @Scheduled(fixedRate = 3 * 60 * 1000L)
20+
@Scheduled(fixedRate = 3 * 60 * 1000L)
2121
void execute() throws InterruptedException {
2222
LOGGER.info("Executing scheduled job");
2323
Thread.sleep(2000L);

sentry-samples/sentry-samples-spring-boot-jakarta-opentelemetry/src/main/java/io/sentry/samples/spring/boot/jakarta/SentryDemoApplication.java

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -33,34 +33,34 @@ RestClient restClient(RestClient.Builder builder) {
3333
return builder.build();
3434
}
3535

36-
// @Bean
37-
// public JobDetailFactoryBean jobDetail() {
38-
// JobDetailFactoryBean jobDetailFactory = new JobDetailFactoryBean();
39-
// jobDetailFactory.setJobClass(SampleJob.class);
40-
// jobDetailFactory.setDurability(true);
41-
// jobDetailFactory.setJobDataAsMap(
42-
// Collections.singletonMap(SENTRY_SLUG_KEY, "monitor_slug_job_detail"));
43-
// return jobDetailFactory;
44-
// }
45-
//
46-
// @Bean
47-
// public SimpleTriggerFactoryBean trigger(JobDetail job) {
48-
// SimpleTriggerFactoryBean trigger = new SimpleTriggerFactoryBean();
49-
// trigger.setJobDetail(job);
50-
// trigger.setRepeatInterval(2 * 60 * 1000); // every two minutes
51-
// trigger.setRepeatCount(SimpleTrigger.REPEAT_INDEFINITELY);
52-
// trigger.setJobDataAsMap(
53-
// Collections.singletonMap(SENTRY_SLUG_KEY, "monitor_slug_simple_trigger"));
54-
// return trigger;
55-
// }
56-
//
57-
// @Bean
58-
// public CronTriggerFactoryBean cronTrigger(JobDetail job) {
59-
// CronTriggerFactoryBean trigger = new CronTriggerFactoryBean();
60-
// trigger.setJobDetail(job);
61-
// trigger.setCronExpression("0 0/5 * ? * *"); // every five minutes
62-
// return trigger;
63-
// }
36+
@Bean
37+
public JobDetailFactoryBean jobDetail() {
38+
JobDetailFactoryBean jobDetailFactory = new JobDetailFactoryBean();
39+
jobDetailFactory.setJobClass(SampleJob.class);
40+
jobDetailFactory.setDurability(true);
41+
jobDetailFactory.setJobDataAsMap(
42+
Collections.singletonMap(SENTRY_SLUG_KEY, "monitor_slug_job_detail"));
43+
return jobDetailFactory;
44+
}
45+
46+
@Bean
47+
public SimpleTriggerFactoryBean trigger(JobDetail job) {
48+
SimpleTriggerFactoryBean trigger = new SimpleTriggerFactoryBean();
49+
trigger.setJobDetail(job);
50+
trigger.setRepeatInterval(2 * 60 * 1000); // every two minutes
51+
trigger.setRepeatCount(SimpleTrigger.REPEAT_INDEFINITELY);
52+
trigger.setJobDataAsMap(
53+
Collections.singletonMap(SENTRY_SLUG_KEY, "monitor_slug_simple_trigger"));
54+
return trigger;
55+
}
56+
57+
@Bean
58+
public CronTriggerFactoryBean cronTrigger(JobDetail job) {
59+
CronTriggerFactoryBean trigger = new CronTriggerFactoryBean();
60+
trigger.setJobDetail(job);
61+
trigger.setCronExpression("0 0/5 * ? * *"); // every five minutes
62+
return trigger;
63+
}
6464

6565
@Bean
6666
public Tracer getTracer() {

0 commit comments

Comments
 (0)