Skip to content

Commit a360064

Browse files
adinauerromtsn
andauthored
Apply suggestions from code review
Co-authored-by: Roman Zavarnitsyn <[email protected]>
1 parent 23dcd1a commit a360064

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -382,15 +382,13 @@ public synchronized void onActivityStarted(final @NotNull Activity activity) {
382382
// working. Moving this to onActivityStarted fixes the problem.
383383
activityFramesTracker.addActivity(activity);
384384
}
385-
if (options.isEnableActivityLifecycleBreadcrumbs()) {
386-
addBreadcrumb(activity, "started");
387-
}
385+
addBreadcrumb(activity, "started");
388386
}
389387

390388
@SuppressLint("NewApi")
391389
@Override
392390
public synchronized void onActivityResumed(final @NotNull Activity activity) {
393-
if (performanceEnabled || options.isEnableActivityLifecycleBreadcrumbs()) {
391+
if (performanceEnabled) {
394392
// app start span
395393
@Nullable final SentryDate appStartStartTime = AppStartState.getInstance().getAppStartTime();
396394
@Nullable final SentryDate appStartEndTime = AppStartState.getInstance().getAppStartEndTime();
@@ -414,8 +412,8 @@ public synchronized void onActivityResumed(final @NotNull Activity activity) {
414412
// its current job. That is, right after the activity draws the layout.
415413
mainHandler.post(() -> onFirstFrameDrawn(ttfdSpan, ttidSpan));
416414
}
417-
addBreadcrumb(activity, "resumed");
418415
}
416+
addBreadcrumb(activity, "resumed");
419417
}
420418

421419
@Override

0 commit comments

Comments
 (0)