Skip to content

Commit 30887df

Browse files
authored
Merge c11bc1c into 32f1546
2 parents 32f1546 + c11bc1c commit 30887df

File tree

3 files changed

+12
-13
lines changed

3 files changed

+12
-13
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
- Remove `PROCESS_COMMAND_ARGS` (`process.command_args`) OpenTelemetry span attribute as it can be very large ([#3664](https://github.com/getsentry/sentry-java/pull/3664))
2727
- Use RECORD_ONLY sampling decision if performance is disabled ([#3659](https://github.com/getsentry/sentry-java/pull/3659))
2828
- Also fix check whether Performance is enabled when making a sampling decision in the OpenTelemetry sampler
29+
- Sentry OpenTelemetry Java Agent now sets Instrumenter to SENTRY (used to be OTEL) ([#3697](https://github.com/getsentry/sentry-java/pull/3697))
2930
- Avoid stopping appStartProfiler after application creation ([#3630](https://github.com/getsentry/sentry-java/pull/3630))
3031
- Session Replay: Correctly detect dominant color for `TextView`s with Spans ([#3682](https://github.com/getsentry/sentry-java/pull/3682))
3132
- Session Replay: Add options to selectively redact/ignore views from being captured. The following options are available: ([#3689](https://github.com/getsentry/sentry-java/pull/3689))

sentry-opentelemetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SentrySpanExporter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ private void createAndFinishSpanForOtelSpan(
214214
parentSentrySpan.getSpanContext().getSpanId(),
215215
new SpanId(spanId));
216216
spanContext.setDescription(spanInfo.getDescription());
217-
spanContext.setInstrumenter(Instrumenter.OTEL);
217+
spanContext.setInstrumenter(Instrumenter.SENTRY);
218218
if (sentrySpanMaybe != null) {
219219
spanContext.setSamplingDecision(sentrySpanMaybe.getSamplingDecision());
220220
spanOptions.setOrigin(sentrySpanMaybe.getSpanContext().getOrigin());
@@ -329,7 +329,7 @@ private void transferSpanDetails(
329329
transactionName == null ? DEFAULT_TRANSACTION_NAME : transactionName);
330330
transactionContext.setTransactionNameSource(transactionNameSource);
331331
transactionContext.setOperation(spanInfo.getOp());
332-
transactionContext.setInstrumenter(Instrumenter.OTEL);
332+
transactionContext.setInstrumenter(Instrumenter.SENTRY);
333333
if (sentrySpanMaybe != null) {
334334
transactionContext.setSamplingDecision(sentrySpanMaybe.getSamplingDecision());
335335
transactionOptions.setOrigin(sentrySpanMaybe.getSpanContext().getOrigin());

sentry/src/main/java/io/sentry/Scopes.java

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -850,17 +850,15 @@ public void flush(long timeoutMillis) {
850850
transactionContext.getOrigin());
851851
transaction = NoOpTransaction.getInstance();
852852

853-
// } else if (!getOptions().getInstrumenter().equals(transactionContext.getInstrumenter()))
854-
// {
855-
// getOptions()
856-
// .getLogger()
857-
// .log(
858-
// SentryLevel.DEBUG,
859-
// "Returning no-op for instrumenter %s as the SDK has been configured to use
860-
// instrumenter %s",
861-
// transactionContext.getInstrumenter(),
862-
// getOptions().getInstrumenter());
863-
// transaction = NoOpTransaction.getInstance();
853+
} else if (!getOptions().getInstrumenter().equals(transactionContext.getInstrumenter())) {
854+
getOptions()
855+
.getLogger()
856+
.log(
857+
SentryLevel.DEBUG,
858+
"Returning no-op for instrumenter %s as the SDK has been configured to use instrumenter %s",
859+
transactionContext.getInstrumenter(),
860+
getOptions().getInstrumenter());
861+
transaction = NoOpTransaction.getInstance();
864862
} else if (!getOptions().isTracingEnabled()) {
865863
getOptions()
866864
.getLogger()

0 commit comments

Comments
 (0)