Skip to content

Commit 2702690

Browse files
committed
Bump OTEL to 1.20; reuse dependency configs
1 parent bc2ec93 commit 2702690

File tree

4 files changed

+31
-18
lines changed

4 files changed

+31
-18
lines changed

buildSrc/src/main/java/Config.kt

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,19 @@ object Config {
132132

133133
val apolloKotlin = "com.apollographql.apollo3:apollo-runtime:3.3.0"
134134

135-
val otelVersion = "1.19.0"
136-
val otelAlphaVersion = "1.19.0-alpha"
137-
val otelJavaagentVersion = "1.19.2"
138-
val otelJavaagentAlphaVersion = "1.19.2-alpha"
135+
object OpenTelemetry {
136+
val otelVersion = "1.20.1"
137+
val otelAlphaVersion = "1.20.1-alpha"
138+
val otelJavaagentVersion = "1.20.2"
139+
val otelJavaagentAlphaVersion = "1.20.2-alpha"
140+
141+
val otelSdk = "io.opentelemetry:opentelemetry-sdk:$otelVersion"
142+
val otelSemconv = "io.opentelemetry:opentelemetry-semconv:$otelAlphaVersion"
143+
val otelJavaAgent = "io.opentelemetry.javaagent:opentelemetry-javaagent:$otelJavaagentVersion"
144+
val otelJavaAgentExtensionApi = "io.opentelemetry.javaagent:opentelemetry-javaagent-extension-api:$otelJavaagentAlphaVersion"
145+
val otelJavaAgentTooling = "io.opentelemetry.javaagent:opentelemetry-javaagent-tooling:$otelJavaagentAlphaVersion"
146+
val otelExtensionAutoconfigureSpi = "io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi:$otelVersion"
147+
}
139148
}
140149

141150
object AnnotationProcessors {

sentry-opentelemetry/sentry-opentelemetry-agent/build.gradle.kts

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,12 @@ fun relocatePackages(shadowJar: ShadowJar) {
1414
// rewrite dependencies calling Logger.getLogger
1515
shadowJar.relocate("java.util.logging.Logger", "io.opentelemetry.javaagent.bootstrap.PatchLogger")
1616

17-
// rewrite library instrumentation dependencies
18-
shadowJar.relocate("io.opentelemetry.instrumentation", "io.opentelemetry.javaagent.shaded.instrumentation")
17+
// prevents conflict with library instrumentation, since these classes live in the bootstrap class loader
18+
shadowJar.relocate("io.opentelemetry.instrumentation", "io.opentelemetry.javaagent.shaded.instrumentation") {
19+
// Exclude resource providers since they live in the agent class loader
20+
exclude("io.opentelemetry.instrumentation.resources.*")
21+
exclude("io.opentelemetry.instrumentation.spring.resources.*")
22+
}
1923

2024
// relocate OpenTelemetry API usage
2125
shadowJar.relocate("io.opentelemetry.api", "io.opentelemetry.javaagent.shaded.io.opentelemetry.api")
@@ -50,7 +54,7 @@ val upstreamAgent = configurations.create("upstreamAgent") {
5054
dependencies {
5155
bootstrapLibs(projects.sentry)
5256
javaagentLibs(projects.sentryOpentelemetry.sentryOpentelemetryAgentcustomization)
53-
upstreamAgent("io.opentelemetry.javaagent:opentelemetry-javaagent:${Config.Libs.otelJavaagentVersion}")
57+
upstreamAgent(Config.Libs.OpenTelemetry.otelJavaAgent)
5458
}
5559

5660
fun isolateClasses(jars: Iterable<File>): CopySpec {
@@ -146,11 +150,11 @@ tasks {
146150
attributes.put("Can-Redefine-Classes", "true")
147151
attributes.put("Can-Retransform-Classes", "true")
148152
attributes.put("Implementation-Vendor", "Sentry")
149-
attributes.put("Implementation-Version", "sentry-${project.version}-otel-${Config.Libs.otelJavaagentVersion}")
153+
attributes.put("Implementation-Version", "sentry-${project.version}-otel-${Config.Libs.OpenTelemetry.otelJavaagentVersion}")
150154
attributes.put("Sentry-Version-Name", project.version)
151155
attributes.put("Sentry-Opentelemetry-SDK-Name", Config.Sentry.SENTRY_OPENTELEMETRY_AGENT_SDK_NAME)
152-
attributes.put("Sentry-Opentelemetry-Version-Name", Config.Libs.otelVersion)
153-
attributes.put("Sentry-Opentelemetry-Javaagent-Version-Name", Config.Libs.otelJavaagentVersion)
156+
attributes.put("Sentry-Opentelemetry-Version-Name", Config.Libs.OpenTelemetry.otelVersion)
157+
attributes.put("Sentry-Opentelemetry-Javaagent-Version-Name", Config.Libs.OpenTelemetry.otelJavaagentVersion)
154158
}
155159
}
156160

sentry-opentelemetry/sentry-opentelemetry-agentcustomization/build.gradle.kts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ dependencies {
2222
compileOnly(projects.sentry)
2323
implementation(projects.sentryOpentelemetry.sentryOpentelemetryCore)
2424

25-
compileOnly("io.opentelemetry:opentelemetry-sdk:${Config.Libs.otelVersion}")
26-
compileOnly("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi:${Config.Libs.otelVersion}")
27-
compileOnly("io.opentelemetry.javaagent:opentelemetry-javaagent-extension-api:${Config.Libs.otelJavaagentAlphaVersion}")
28-
compileOnly("io.opentelemetry.javaagent:opentelemetry-javaagent-tooling:${Config.Libs.otelJavaagentAlphaVersion}")
25+
compileOnly(Config.Libs.OpenTelemetry.otelSdk)
26+
compileOnly(Config.Libs.OpenTelemetry.otelExtensionAutoconfigureSpi)
27+
compileOnly(Config.Libs.OpenTelemetry.otelJavaAgentExtensionApi)
28+
compileOnly(Config.Libs.OpenTelemetry.otelJavaAgentTooling)
2929

3030
compileOnly(Config.CompileOnly.nopen)
3131
errorprone(Config.CompileOnly.nopenChecker)

sentry-opentelemetry/sentry-opentelemetry-core/build.gradle.kts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ tasks.withType<KotlinCompile>().configureEach {
2121
dependencies {
2222
compileOnly(projects.sentry)
2323

24-
compileOnly("io.opentelemetry:opentelemetry-sdk:${Config.Libs.otelVersion}")
25-
compileOnly("io.opentelemetry:opentelemetry-semconv:${Config.Libs.otelAlphaVersion}")
24+
compileOnly(Config.Libs.OpenTelemetry.otelSdk)
25+
compileOnly(Config.Libs.OpenTelemetry.otelSemconv)
2626

2727
compileOnly(Config.CompileOnly.nopen)
2828
errorprone(Config.CompileOnly.nopenChecker)
@@ -37,8 +37,8 @@ dependencies {
3737
testImplementation(Config.TestLibs.mockitoKotlin)
3838
testImplementation(Config.TestLibs.awaitility)
3939

40-
testImplementation("io.opentelemetry:opentelemetry-sdk:${Config.Libs.otelVersion}")
41-
testImplementation("io.opentelemetry:opentelemetry-semconv:${Config.Libs.otelAlphaVersion}")
40+
testImplementation(Config.Libs.OpenTelemetry.otelSdk)
41+
testImplementation(Config.Libs.OpenTelemetry.otelSemconv)
4242
}
4343

4444
configure<SourceSetContainer> {

0 commit comments

Comments
 (0)