From c5bca5a8b465c0193b5bb0bf14edf103e25afef5 Mon Sep 17 00:00:00 2001 From: Mischan Toosarani-Hausberger Date: Mon, 30 May 2022 18:10:00 +0200 Subject: [PATCH 1/2] ref(native): Clarify before_send with Crashpad --- src/includes/configuration/before-send/native.mdx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/includes/configuration/before-send/native.mdx b/src/includes/configuration/before-send/native.mdx index f19f51ed11b60..eaa94f546fa62 100644 --- a/src/includes/configuration/before-send/native.mdx +++ b/src/includes/configuration/before-send/native.mdx @@ -17,8 +17,8 @@ int main(void) { The callback is executed in the same thread as the call to `sentry_capture_event`. Work performed by the function may thus block the executing thread. For this reason, consider avoiding heavy work in `before_send`. - + -The Crashpad Backend sends Minidumps with an additional event payload out-of-process. `before_send` hooks are not invoked when capturing crashes using Crashpad. +The Crashpad backend on macOS currently has no support for notifying the crashing process and can thus not correctly terminate sessions or call the registered `before_send` hook. It will also lose any events queued for sending at the time of the crash. From e13d8fcc0739c218fd85b314225f11a169af7ac4 Mon Sep 17 00:00:00 2001 From: Mischan Toosarani-Hausberger Date: Wed, 1 Jun 2022 14:53:14 +0200 Subject: [PATCH 2/2] ref(native): improve wording in before-send Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> --- src/includes/configuration/before-send/native.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/includes/configuration/before-send/native.mdx b/src/includes/configuration/before-send/native.mdx index eaa94f546fa62..b5d2e3a373948 100644 --- a/src/includes/configuration/before-send/native.mdx +++ b/src/includes/configuration/before-send/native.mdx @@ -19,6 +19,6 @@ The callback is executed in the same thread as the call to `sentry_capture_event -The Crashpad backend on macOS currently has no support for notifying the crashing process and can thus not correctly terminate sessions or call the registered `before_send` hook. It will also lose any events queued for sending at the time of the crash. +The Crashpad backend on macOS doesn't currently support notifying the crashing process and thus can't correctly terminate sessions or call the registered `before_send` hook. It will also lose any events queued for sending at the time of the crash.