From 97729cb5a9a896c6ee14f72cb229d8adac9b3371 Mon Sep 17 00:00:00 2001 From: Nicholas Meisenheimer <76002357+souredoutlook@users.noreply.github.com> Date: Wed, 25 May 2022 15:33:00 -0400 Subject: [PATCH 1/4] clarify GetSpan GetSpan will return an ongoing Transaction or Span that is on the Scope. --- src/includes/performance/retrieve-transaction/dotnet.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/includes/performance/retrieve-transaction/dotnet.mdx b/src/includes/performance/retrieve-transaction/dotnet.mdx index 03e2bf18240af2..a05ab1d088b6c2 100644 --- a/src/includes/performance/retrieve-transaction/dotnet.mdx +++ b/src/includes/performance/retrieve-transaction/dotnet.mdx @@ -1,6 +1,6 @@ ## Retrieve a Transaction -In cases where you want to attach Spans to an already ongoing Transaction you can use `Sentry#GetSpan`. This method will return a `SentryTransaction` in case there is a running Transaction or a `Span` in case there is already a running Span, otherwise it returns `null`. +In cases where you want to attach Spans to an already ongoing Transaction you can use `Sentry#GetSpan`. If there is a running Transaction or Span currently on the scope, this method will return a `SentryTransaction` or `Span`, otherwise it returns `null`. ```csharp using Sentry; From cee5a6727b807ae18598bf32713f9ee9fee629f5 Mon Sep 17 00:00:00 2001 From: Nicholas Meisenheimer <76002357+souredoutlook@users.noreply.github.com> Date: Thu, 26 May 2022 11:44:25 -0400 Subject: [PATCH 2/4] fix punctuation in changes to /retrieve-transaction/dotnet.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> --- src/includes/performance/retrieve-transaction/dotnet.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/includes/performance/retrieve-transaction/dotnet.mdx b/src/includes/performance/retrieve-transaction/dotnet.mdx index a05ab1d088b6c2..36ad02efa163c6 100644 --- a/src/includes/performance/retrieve-transaction/dotnet.mdx +++ b/src/includes/performance/retrieve-transaction/dotnet.mdx @@ -1,6 +1,6 @@ ## Retrieve a Transaction -In cases where you want to attach Spans to an already ongoing Transaction you can use `Sentry#GetSpan`. If there is a running Transaction or Span currently on the scope, this method will return a `SentryTransaction` or `Span`, otherwise it returns `null`. +In cases where you want to attach Spans to an already ongoing Transaction you can use `Sentry#GetSpan`. If there is a running Transaction or Span currently on the scope, this method will return a `SentryTransaction` or `Span`; otherwise, it returns `null`. ```csharp using Sentry; From fa18d014fe3cf0eeb5de036f0c5f2c13bac153d7 Mon Sep 17 00:00:00 2001 From: Matt Johnson-Pint Date: Thu, 26 May 2022 14:47:47 -0700 Subject: [PATCH 3/4] Update src/includes/performance/retrieve-transaction/dotnet.mdx --- src/includes/performance/retrieve-transaction/dotnet.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/includes/performance/retrieve-transaction/dotnet.mdx b/src/includes/performance/retrieve-transaction/dotnet.mdx index 36ad02efa163c6..c0ea6669646a17 100644 --- a/src/includes/performance/retrieve-transaction/dotnet.mdx +++ b/src/includes/performance/retrieve-transaction/dotnet.mdx @@ -1,6 +1,6 @@ ## Retrieve a Transaction -In cases where you want to attach Spans to an already ongoing Transaction you can use `Sentry#GetSpan`. If there is a running Transaction or Span currently on the scope, this method will return a `SentryTransaction` or `Span`; otherwise, it returns `null`. +In cases where you want to attach Spans to an already ongoing Transaction you can use `Sentry.GetSpan`. If there is a running Transaction or Span currently on the scope, this method will return a `SentryTransaction` or `Span`; otherwise, it returns `null`. ```csharp using Sentry; From fc95891797cd8624fdefc6d566621db30cc9c581 Mon Sep 17 00:00:00 2001 From: Bruno Garcia Date: Wed, 1 Jun 2022 08:20:48 -0400 Subject: [PATCH 4/4] Apply suggestions from code review --- src/includes/performance/retrieve-transaction/dotnet.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/includes/performance/retrieve-transaction/dotnet.mdx b/src/includes/performance/retrieve-transaction/dotnet.mdx index c0ea6669646a17..50b4feed2090f0 100644 --- a/src/includes/performance/retrieve-transaction/dotnet.mdx +++ b/src/includes/performance/retrieve-transaction/dotnet.mdx @@ -1,6 +1,6 @@ ## Retrieve a Transaction -In cases where you want to attach Spans to an already ongoing Transaction you can use `Sentry.GetSpan`. If there is a running Transaction or Span currently on the scope, this method will return a `SentryTransaction` or `Span`; otherwise, it returns `null`. +In cases where you want to attach Spans to an already ongoing Transaction you can use `SentrySdk.GetSpan()`. If there is a running Transaction or Span currently on the scope, this method will return a `SentryTransaction` or `Span`; otherwise, it returns `null`. ```csharp using Sentry;