From 3a18d1130b8c20d9447240109716e5894e6d15e8 Mon Sep 17 00:00:00 2001 From: Chingis Gomboev Date: Wed, 23 Feb 2022 21:41:20 +0800 Subject: [PATCH 1/8] proposing new options for ignoring sentry errors --- src/platforms/node/guides/aws-lambda/index.mdx | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/platforms/node/guides/aws-lambda/index.mdx b/src/platforms/node/guides/aws-lambda/index.mdx index d3076e1e77784..503b56d88e977 100644 --- a/src/platforms/node/guides/aws-lambda/index.mdx +++ b/src/platforms/node/guides/aws-lambda/index.mdx @@ -100,6 +100,19 @@ exports.handler = Sentry.AWSLambda.wrapHandler(() => { // `first` and `second` errors are captured ``` +## Ignore Sentry errors +_(New in version 6.17.10)_ + +By default, Sentry fails lambda invocation if it unable to send reports to the server. +In this case, even if all reported erros were handled and your handler executed successfully, Sentry will fail whole lambda invocation. + +The `ignoreSentryErrors` (default: `false`) option ignores all the errors raised by Sentry itself + +```javascript {tabTitle:ignoreSentryErrors} +exports.handler = Sentry.AWSLambda.wrapHandler(yourHandler, { ignoreSentryErrors: true }); +// it will ignore any errors raised by sentry sdk on attempt to send reports to the server +``` + ## Behavior With the AWS Lambda integration enabled, the Node SDK will: From ff64885da8b37ccdffa630b80fa40ef52c1b33ac Mon Sep 17 00:00:00 2001 From: Chingis Gomboev Date: Wed, 23 Feb 2022 21:49:20 +0800 Subject: [PATCH 2/8] fix typo --- src/platforms/node/guides/aws-lambda/index.mdx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/platforms/node/guides/aws-lambda/index.mdx b/src/platforms/node/guides/aws-lambda/index.mdx index 503b56d88e977..4d67fc1cf0d3f 100644 --- a/src/platforms/node/guides/aws-lambda/index.mdx +++ b/src/platforms/node/guides/aws-lambda/index.mdx @@ -104,9 +104,9 @@ exports.handler = Sentry.AWSLambda.wrapHandler(() => { _(New in version 6.17.10)_ By default, Sentry fails lambda invocation if it unable to send reports to the server. -In this case, even if all reported erros were handled and your handler executed successfully, Sentry will fail whole lambda invocation. +In this case, even if all reported errors were handled and your handler executed successfully, Sentry will fail whole lambda invocation. -The `ignoreSentryErrors` (default: `false`) option ignores all the errors raised by Sentry itself +The `ignoreSentryErrors` (default: `false`) option ignores all the errors raised by Sentry ```javascript {tabTitle:ignoreSentryErrors} exports.handler = Sentry.AWSLambda.wrapHandler(yourHandler, { ignoreSentryErrors: true }); From 4dce5d3465948540816c7c46db6b50404487189a Mon Sep 17 00:00:00 2001 From: Chingis Gomboev Date: Wed, 23 Feb 2022 22:12:51 +0800 Subject: [PATCH 3/8] Update src/platforms/node/guides/aws-lambda/index.mdx Co-authored-by: Abhijeet Prasad --- src/platforms/node/guides/aws-lambda/index.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/platforms/node/guides/aws-lambda/index.mdx b/src/platforms/node/guides/aws-lambda/index.mdx index 4d67fc1cf0d3f..e26f59501713b 100644 --- a/src/platforms/node/guides/aws-lambda/index.mdx +++ b/src/platforms/node/guides/aws-lambda/index.mdx @@ -103,7 +103,7 @@ exports.handler = Sentry.AWSLambda.wrapHandler(() => { ## Ignore Sentry errors _(New in version 6.17.10)_ -By default, Sentry fails lambda invocation if it unable to send reports to the server. +By default, Sentry fails lambda invocation if it is unable to send events to Sentry. In this case, even if all reported errors were handled and your handler executed successfully, Sentry will fail whole lambda invocation. The `ignoreSentryErrors` (default: `false`) option ignores all the errors raised by Sentry From 41c3aea0fcc28cc67a3995678b5cfa4dc19ea619 Mon Sep 17 00:00:00 2001 From: Chingis Gomboev Date: Wed, 23 Feb 2022 22:13:17 +0800 Subject: [PATCH 4/8] Update src/platforms/node/guides/aws-lambda/index.mdx Co-authored-by: Abhijeet Prasad --- src/platforms/node/guides/aws-lambda/index.mdx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/platforms/node/guides/aws-lambda/index.mdx b/src/platforms/node/guides/aws-lambda/index.mdx index e26f59501713b..b68c695ece9de 100644 --- a/src/platforms/node/guides/aws-lambda/index.mdx +++ b/src/platforms/node/guides/aws-lambda/index.mdx @@ -109,8 +109,10 @@ In this case, even if all reported errors were handled and your handler executed The `ignoreSentryErrors` (default: `false`) option ignores all the errors raised by Sentry ```javascript {tabTitle:ignoreSentryErrors} -exports.handler = Sentry.AWSLambda.wrapHandler(yourHandler, { ignoreSentryErrors: true }); -// it will ignore any errors raised by sentry sdk on attempt to send reports to the server +exports.handler = Sentry.AWSLambda.wrapHandler(yourHandler, { + // Ignore any errors raised by the Sentry SDK on attempts to send events to Sentry + ignoreSentryErrors: true, +}); ``` ## Behavior From c867c5aeff5c4b508e835eb6454d34fbbeccbfc4 Mon Sep 17 00:00:00 2001 From: Chingis Gomboev Date: Thu, 24 Feb 2022 09:18:54 +0800 Subject: [PATCH 5/8] Update src/platforms/node/guides/aws-lambda/index.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> --- src/platforms/node/guides/aws-lambda/index.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/platforms/node/guides/aws-lambda/index.mdx b/src/platforms/node/guides/aws-lambda/index.mdx index b68c695ece9de..adeb88e3b66b0 100644 --- a/src/platforms/node/guides/aws-lambda/index.mdx +++ b/src/platforms/node/guides/aws-lambda/index.mdx @@ -100,7 +100,7 @@ exports.handler = Sentry.AWSLambda.wrapHandler(() => { // `first` and `second` errors are captured ``` -## Ignore Sentry errors +## Ignore Sentry Errors _(New in version 6.17.10)_ By default, Sentry fails lambda invocation if it is unable to send events to Sentry. From 5447785e0f8387bbd046b1c66a51f638da9f0407 Mon Sep 17 00:00:00 2001 From: Chingis Gomboev Date: Thu, 24 Feb 2022 09:19:02 +0800 Subject: [PATCH 6/8] Update src/platforms/node/guides/aws-lambda/index.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> --- src/platforms/node/guides/aws-lambda/index.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/platforms/node/guides/aws-lambda/index.mdx b/src/platforms/node/guides/aws-lambda/index.mdx index adeb88e3b66b0..a40035936ad1c 100644 --- a/src/platforms/node/guides/aws-lambda/index.mdx +++ b/src/platforms/node/guides/aws-lambda/index.mdx @@ -103,7 +103,7 @@ exports.handler = Sentry.AWSLambda.wrapHandler(() => { ## Ignore Sentry Errors _(New in version 6.17.10)_ -By default, Sentry fails lambda invocation if it is unable to send events to Sentry. +By default, Sentry fails Lambda invocation if it is unable to send events to Sentry. In this case, even if all reported errors were handled and your handler executed successfully, Sentry will fail whole lambda invocation. The `ignoreSentryErrors` (default: `false`) option ignores all the errors raised by Sentry From e8cd0fcfa6439840c5f85e973e5105327ee1fda2 Mon Sep 17 00:00:00 2001 From: Chingis Gomboev Date: Thu, 24 Feb 2022 09:19:08 +0800 Subject: [PATCH 7/8] Update src/platforms/node/guides/aws-lambda/index.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> --- src/platforms/node/guides/aws-lambda/index.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/platforms/node/guides/aws-lambda/index.mdx b/src/platforms/node/guides/aws-lambda/index.mdx index a40035936ad1c..610200f0cdd99 100644 --- a/src/platforms/node/guides/aws-lambda/index.mdx +++ b/src/platforms/node/guides/aws-lambda/index.mdx @@ -104,7 +104,7 @@ exports.handler = Sentry.AWSLambda.wrapHandler(() => { _(New in version 6.17.10)_ By default, Sentry fails Lambda invocation if it is unable to send events to Sentry. -In this case, even if all reported errors were handled and your handler executed successfully, Sentry will fail whole lambda invocation. +In this case, even if all reported errors were handled and your handler executed successfully, Sentry will fail the whole Lambda invocation. The `ignoreSentryErrors` (default: `false`) option ignores all the errors raised by Sentry From 3e89f7c39fe010d309fc92da35fee3f8da060aff Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Thu, 24 Feb 2022 08:58:24 -0500 Subject: [PATCH 8/8] Update src/platforms/node/guides/aws-lambda/index.mdx --- src/platforms/node/guides/aws-lambda/index.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/platforms/node/guides/aws-lambda/index.mdx b/src/platforms/node/guides/aws-lambda/index.mdx index 610200f0cdd99..04e8e3b495074 100644 --- a/src/platforms/node/guides/aws-lambda/index.mdx +++ b/src/platforms/node/guides/aws-lambda/index.mdx @@ -101,7 +101,7 @@ exports.handler = Sentry.AWSLambda.wrapHandler(() => { ``` ## Ignore Sentry Errors -_(New in version 6.17.10)_ +_(New in version 6.18.0)_ By default, Sentry fails Lambda invocation if it is unable to send events to Sentry. In this case, even if all reported errors were handled and your handler executed successfully, Sentry will fail the whole Lambda invocation.