Skip to content

doc(serverless/aws-lambda)/Add documentation for captureAllSettledReasons option #4374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 12, 2021
Merged

doc(serverless/aws-lambda)/Add documentation for captureAllSettledReasons option #4374

merged 11 commits into from
Nov 12, 2021

Conversation

@J4YF7O
Copy link
Contributor

@J4YF7O J4YF7O commented Nov 9, 2021

@vercel
Copy link

vercel bot commented Nov 9, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/85ffvvnJapYhp6GZpzagPaJ4qR8s
✅ Preview: https://sentry-docs-git-fork-j4yf7o-feat-serverlessawsservice-ad-fdfc8c.sentry.dev

@J4YF7O J4YF7O mentioned this pull request Nov 9, 2021
Merged
2 tasks
@J4YF7O J4YF7O changed the title feat(serverless/aws-lambda)/Add documentation for captureAllSettledReasons option doc(serverless/aws-lambda)/Add documentation for captureAllSettledReasons option Nov 9, 2021
@imatwawana imatwawana requested review from a team, iker-barriocanal and sl0thentr0py and removed request for a team November 9, 2021 13:27
imatwawana
imatwawana suggested changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! This is just a review of the language and technical review will happen next.

@J4YF7O
Copy link
Contributor Author

J4YF7O commented Nov 9, 2021

Sorry for my french... Thanks for the corrections :)

Moreover I have no idea about the version, how will you manage this case ? 🤔

iker-barriocanal
iker-barriocanal suggested changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributing! Some small changes to align with the docs style.

AbhiPrasad
AbhiPrasad approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version should be 6.14.3 as per: https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md#6142 (6.14.2 has a problem, it was removed from npm)

Thanks a lot for the SDK PR + docs, appreciate it!

@J4YF7O
Copy link
Contributor Author

J4YF7O commented Nov 12, 2021

Version set in f8f45f5

PR is ready to merge (IMO)

@AbhiPrasad AbhiPrasad merged commit 6f99d5b into getsentry:master Nov 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@sl0thentr0py sl0thentr0py Awaiting requested review from sl0thentr0py sl0thentr0py was automatically assigned from getsentry/team-javascript-sdks

+2 more reviewers

@iker-barriocanal iker-barriocanal iker-barriocanal requested changes

@imatwawana imatwawana imatwawana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@J4YF7O @AbhiPrasad @iker-barriocanal @imatwawana