Skip to content

Conversation

@PeloWriter
Copy link
Contributor

User Feedback content was a bit confusing to manage. This PR pulls the content into one common file, with either the embeddable widget or the API content (and sometimes both) based on the SDK.

@PeloWriter PeloWriter requested review from a team and marandaneto as code owners April 26, 2021 21:53
@vercel
Copy link

vercel bot commented Apr 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/J3Amgi5hi7BZuSgaHHfucxkWtRQD
✅ Preview: https://sentry-docs-git-update-user-feedback-common.sentry.dev

@PeloWriter PeloWriter linked an issue Apr 26, 2021 that may be closed by this pull request
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion for improving, but LGTM

name="capture-event" /> and <PlatformIdentifier name="capture-exception" />.
There is also a function called <PlatformIdentifier name="last-event-id" />
that returns the ID of the most recently sent event.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a note that for users using ASP.NET or ASP.NET Core, there's a specific content for this?
We have overrides for this on those that include a proper snippet:

https://docs.sentry.io/platforms/dotnet/guides/aspnet/enriching-events/user-feedback/#integration

https://docs.sentry.io/platforms/dotnet/guides/aspnetcore/enriching-events/user-feedback/#integration

I'm just afraid folks land on .NET and click on User Feedback on the left without understanding that there's a "better" content if they are in fact using a web technology.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that in here: https://sentry-docs-kl81mjezf.sentry.dev/platforms/dotnet/enriching-events/user-feedback/

There's no indication that this snippet:
image

Is not what you need if you're on ASP.NET or ASP.NET Core (90% of all Web Apps in .NET fall into one of these two)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, got it. Yes, we can do that.

@PeloWriter PeloWriter merged commit 7ea93f3 into master Apr 27, 2021
@PeloWriter PeloWriter deleted the update/user-feedback-common branch April 27, 2021 22:34
@philipphofmann
Copy link
Member

Thanks, @PeloWriter for improving this 👏🏼

@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User Feedback content

4 participants