-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update user feedback to common #3467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/J3Amgi5hi7BZuSgaHHfucxkWtRQD |
bruno-garcia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one suggestion for improving, but LGTM
| name="capture-event" /> and <PlatformIdentifier name="capture-exception" />. | ||
| There is also a function called <PlatformIdentifier name="last-event-id" /> | ||
| that returns the ID of the most recently sent event. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a note that for users using ASP.NET or ASP.NET Core, there's a specific content for this?
We have overrides for this on those that include a proper snippet:
https://docs.sentry.io/platforms/dotnet/guides/aspnet/enriching-events/user-feedback/#integration
I'm just afraid folks land on .NET and click on User Feedback on the left without understanding that there's a "better" content if they are in fact using a web technology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant that in here: https://sentry-docs-kl81mjezf.sentry.dev/platforms/dotnet/enriching-events/user-feedback/
There's no indication that this snippet:

Is not what you need if you're on ASP.NET or ASP.NET Core (90% of all Web Apps in .NET fall into one of these two)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, got it. Yes, we can do that.
|
Thanks, @PeloWriter for improving this 👏🏼 |
User Feedback content was a bit confusing to manage. This PR pulls the content into one common file, with either the embeddable widget or the API content (and sometimes both) based on the SDK.