Skip to content

Conversation

@kamilogorek
Copy link
Contributor

not sure if the example should be there, but some people may want to learn about Wasm and try it out I guess(?).

@vercel
Copy link

vercel bot commented Jan 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/ibegickl3/sentry.dev
✅ Preview: https://sentry-docs-git-wasm-docs.sentry.dev

Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ ⭐ ⭐ ⭐ ⭐
Thanks for adding this to the docs! A few suggestions.

Copy link
Contributor

@PeloWriter PeloWriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to move away from the common content for Wasm?

description: "Learn how to use Sentry's Wasm integration and how it automatically reports errors and exceptions in your Wasm module."
---

Sentry's Wasm integration enhances the Browser SDK, and allows it to provide more detailed debug information not only for the error itself, but also for the entire module it was executed from. It includes things like Debug IDs, Debug Files, Code IDs, Code Files and memory addresses.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need its own Getting Started page? Far easier to simply use the guidelines here - https://docs.sentry.io/contributing/approach/write-getting-started/

@kamilogorek
Copy link
Contributor Author

Search synonym group (wasm <> webassembly) - getsentry/sentry-global-search#7

@kamilogorek
Copy link
Contributor Author

@PeloWriter Wasm is an integration, not a standalone SDK, that's why I didn't reuse the same page. Its content is resembling the one that we have for Angular 1 rather than the rest of pages - https://docs.sentry.io/platforms/javascript/guides/angular/angular1/ However, I believe it's important enough to make it a standalone page for marketing purposes, as Wasm is definitely something that we want to tell the world about.

@HazAT HazAT merged commit 2ca5f9d into master Jan 22, 2021
@HazAT HazAT deleted the wasm-docs branch January 22, 2021 09:53
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants