-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(sentry-javascript): Add @sentry/wasm page #2923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/ibegickl3/sentry.dev |
rhcarvalho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ ⭐ ⭐ ⭐ ⭐
Thanks for adding this to the docs! A few suggestions.
Co-authored-by: Rodolfo Carvalho <[email protected]>
Co-authored-by: Rodolfo Carvalho <[email protected]>
PeloWriter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to move away from the common content for Wasm?
| description: "Learn how to use Sentry's Wasm integration and how it automatically reports errors and exceptions in your Wasm module." | ||
| --- | ||
|
|
||
| Sentry's Wasm integration enhances the Browser SDK, and allows it to provide more detailed debug information not only for the error itself, but also for the entire module it was executed from. It includes things like Debug IDs, Debug Files, Code IDs, Code Files and memory addresses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need its own Getting Started page? Far easier to simply use the guidelines here - https://docs.sentry.io/contributing/approach/write-getting-started/
|
Search synonym group (wasm <> webassembly) - getsentry/sentry-global-search#7 |
|
@PeloWriter Wasm is an integration, not a standalone SDK, that's why I didn't reuse the same page. Its content is resembling the one that we have for Angular 1 rather than the rest of pages - https://docs.sentry.io/platforms/javascript/guides/angular/angular1/ However, I believe it's important enough to make it a standalone page for marketing purposes, as Wasm is definitely something that we want to tell the world about. |
not sure if the example should be there, but some people may want to learn about Wasm and try it out I guess(?).