Skip to content

Conversation

@priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Jan 20, 2025

@vercel
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 2:11pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 2:11pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 2:11pm

@codecov
Copy link

codecov bot commented Jan 20, 2025

Bundle Report

Changes will increase total bundle size by 1.14kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.37MB 1.15kB (0.01%) ⬆️
sentry-docs-client-array-push 9.3MB 6 bytes (-0.0%) ⬇️

## Install

Sentry captures data by using an SDK within your application’s runtime.
Sentry captures data by using an SDK within your application’s runtime.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this weird formatting was probably my editor? it is annoying

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    If you have prettier enabled it might just be formatting on save, getting rid of these extra trailing spaces.

@priscilawebdev priscilawebdev requested review from a team, bitsandfoxes and bruno-garcia and removed request for a team January 20, 2025 16:17
@priscilawebdev priscilawebdev changed the title ref(crash-reports): Update various parts of docs with 'Store Minidumps As Attachments' ref(crash-reports): Update various parts of docs, adding 'Store Minidumps As Attachments' section Jan 20, 2025
@priscilawebdev priscilawebdev changed the title ref(crash-reports): Update various parts of docs, adding 'Store Minidumps As Attachments' section ref(native): Update various parts of docs, adding 'Store Minidumps As Attachments' section Jan 20, 2025
@priscilawebdev priscilawebdev marked this pull request as ready for review January 20, 2025 16:22
Comment on lines 66 to 72
### Access to Attachments
## Store Minidumps as Attachments

To limit access to attachments, navigate to your organization's **General Settings**, then select the _Attachments Access_ dropdown to set appropriate access — any member of your organization, the organization billing owner, member, admin, manager, or owner.
<Include name="store-minidumps-as-attachments-intro" />

<Include name="common-imgs/attachments-access" />
<Alert level="note">☝ This feature is currently only supported for Desktop Platforms, Windows, Linux and MacOS.</Alert>

By default, access is granted to all members when storage is enabled. If a member does not have access to the project, the ability to download an attachment is not available; the button will be greyed out in Sentry. The member may only view that an attachment is stored.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here we can leave the ### Access to Attachmens as is. I don't see why we need to replace this with the minidump info. That could be an additional paragraph.

@priscilawebdev priscilawebdev enabled auto-merge (squash) January 21, 2025 14:00
@@ -0,0 +1,3 @@
Minidumps may contain sensitive information about the target system, such as environment variables, local pathnames, or in-memory representations of input fields, including passwords. By default, Sentry only uses minidump files to create events and immediately drops them. All sensitive information is stripped from the resulting events.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Minidumps may contain sensitive information about the target system, such as environment variables, local pathnames, or in-memory representations of input fields, including passwords. By default, Sentry only uses minidump files to create events and immediately drops them. All sensitive information is stripped from the resulting events.
[Minidumps](/platforms/native/guides/minidumps/#what-is-a-minidump) may contain sensitive information about the target system, such as environment variables, local pathnames, or in-memory representations of input fields, including passwords. By default, Sentry only uses minidump files to create events and immediately drops them. All sensitive information is stripped from the resulting events.

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the updates! 🏄‍♂️

@priscilawebdev priscilawebdev merged commit 60b1a91 into master Jan 21, 2025
11 checks passed
@priscilawebdev priscilawebdev deleted the priscila/ref/native-platforms/expand-on-the-ability-to-store-minidumps branch January 21, 2025 18:01
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand on the ability to store minidumps

4 participants