Skip to content

Conversation

@chargome
Copy link
Member

@chargome chargome commented Nov 15, 2024

NOTE: wait for release @sentry/nestjs 8.39.0 before merging this

@chargome chargome self-assigned this Nov 15, 2024
@vercel
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 1:35pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 1:35pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 1:35pm

@chargome chargome changed the title docs(nestjs): Updates docs(nestjs): Update NestJS setup + event emitter Nov 15, 2024
@codecov
Copy link

codecov bot commented Nov 15, 2024

Bundle Report

Changes will increase total bundle size by 255.88kB (1.31%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.38MB 255.89kB (2.53%) ⬆️
sentry-docs-client-array-push 9.02MB 6 bytes (-0.0%) ⬇️

Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chargome I'd probably turn this into a draft PR so we don't accidentally merge it.

@chargome chargome marked this pull request as draft November 18, 2024 15:07
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions, looks good to me! Thanks for adding.

@chargome chargome merged commit 78c9c00 into master Nov 22, 2024
11 checks passed
@chargome chargome deleted the cg/nestjs-updates branch November 22, 2024 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@sentry/nestjs graphql crashes the application on 404

4 participants