From 487ab2965ae6943bf862f598f17012c038607214 Mon Sep 17 00:00:00 2001 From: Antonis Lilis Date: Thu, 3 Oct 2024 12:48:41 +0300 Subject: [PATCH 1/7] Adds a note that source maps are not uploaded for debug --- docs/platforms/react-native/sourcemaps/uploading/expo.mdx | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/platforms/react-native/sourcemaps/uploading/expo.mdx b/docs/platforms/react-native/sourcemaps/uploading/expo.mdx index 8764c1b8018cb..9b6094bb8f14a 100644 --- a/docs/platforms/react-native/sourcemaps/uploading/expo.mdx +++ b/docs/platforms/react-native/sourcemaps/uploading/expo.mdx @@ -47,6 +47,7 @@ npx sentry-expo-upload-sourcemaps dist - `dist` is the default output directory of `eas update`. - Uploaded source maps have no associated releases. This is expected as updates can apply to multiple releases. +- Uploading of source maps for debug or simulator builds is disabled. ## Notes From 6d154f79f78b7773d441d927d35ff2e81e46ebb8 Mon Sep 17 00:00:00 2001 From: Antonis Lilis Date: Mon, 7 Oct 2024 09:52:34 +0300 Subject: [PATCH 2/7] Moves debug source maps notice to the correct section --- docs/platforms/react-native/sourcemaps/uploading/expo.mdx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/platforms/react-native/sourcemaps/uploading/expo.mdx b/docs/platforms/react-native/sourcemaps/uploading/expo.mdx index 9b6094bb8f14a..8372da47c1aab 100644 --- a/docs/platforms/react-native/sourcemaps/uploading/expo.mdx +++ b/docs/platforms/react-native/sourcemaps/uploading/expo.mdx @@ -17,7 +17,7 @@ Sentry's React Native SDK works out of the box with Expo applications. To see re ## Automatic Upload for Release -When the Sentry Expo Plugin `@sentry/react-native/expo` and the Sentry Metro Pugin are added to your application configuration, source maps for the native builds are uploaded automatically during EAS Builds and when building the native application release locally using `npx expo prebuild`. +When the Sentry Expo Plugin `@sentry/react-native/expo` and the Sentry Metro Pugin are added to your application configuration, source maps for the native builds are uploaded automatically during EAS Builds and when building the native application release locally using `npx expo prebuild`. Note that uploading source maps for debug or simulator builds is disabled, as symbolication is handled by the Metro dev server. ## Manual Upload for EAS Updates @@ -47,7 +47,6 @@ npx sentry-expo-upload-sourcemaps dist - `dist` is the default output directory of `eas update`. - Uploaded source maps have no associated releases. This is expected as updates can apply to multiple releases. -- Uploading of source maps for debug or simulator builds is disabled. ## Notes From e339fd8a050c0d61445cd692164855eb0591491b Mon Sep 17 00:00:00 2001 From: Antonis Lilis Date: Mon, 7 Oct 2024 09:53:35 +0300 Subject: [PATCH 3/7] Adds a debug source maps notice on the main source maps page --- docs/platforms/react-native/sourcemaps/index.mdx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/platforms/react-native/sourcemaps/index.mdx b/docs/platforms/react-native/sourcemaps/index.mdx index f575ffa3ad012..9c1f2218a3c04 100644 --- a/docs/platforms/react-native/sourcemaps/index.mdx +++ b/docs/platforms/react-native/sourcemaps/index.mdx @@ -50,3 +50,7 @@ sentry { uploadNativeSymbols = shouldSentryAutoUpload() } ``` + +### Debug and Simulator Builds + +Note that uploading source maps for debug or simulator builds is disabled because symbolication is handled directly by the Metro development server. In a development environment, Metro automatically provides the symbolication needed to translate stack traces into readable source code. As a result, there is no need to upload source maps for these types of builds. \ No newline at end of file From 19ff4684f50b9180a1bc8442a15754d1d565f8dc Mon Sep 17 00:00:00 2001 From: Antonis Lilis Date: Mon, 7 Oct 2024 11:45:32 +0300 Subject: [PATCH 4/7] Removes simulator builds from the note Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> --- docs/platforms/react-native/sourcemaps/index.mdx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/platforms/react-native/sourcemaps/index.mdx b/docs/platforms/react-native/sourcemaps/index.mdx index 9c1f2218a3c04..241489f598d8e 100644 --- a/docs/platforms/react-native/sourcemaps/index.mdx +++ b/docs/platforms/react-native/sourcemaps/index.mdx @@ -51,6 +51,6 @@ sentry { } ``` -### Debug and Simulator Builds +### Debug Builds -Note that uploading source maps for debug or simulator builds is disabled because symbolication is handled directly by the Metro development server. In a development environment, Metro automatically provides the symbolication needed to translate stack traces into readable source code. As a result, there is no need to upload source maps for these types of builds. \ No newline at end of file +Note that automatic uploading of source maps for debug builds is disabled because symbolication is handled directly by the Metro development server. In a development environment, Metro automatically provides the symbolication needed to translate stack traces into readable source code. As a result, there is no need to upload source maps for these types of builds. \ No newline at end of file From 545f92d3cda698f89894eaec3d71eddeadb7855a Mon Sep 17 00:00:00 2001 From: Antonis Lilis Date: Mon, 7 Oct 2024 11:46:03 +0300 Subject: [PATCH 5/7] Removes simulator build from the expo note Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> --- docs/platforms/react-native/sourcemaps/uploading/expo.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/platforms/react-native/sourcemaps/uploading/expo.mdx b/docs/platforms/react-native/sourcemaps/uploading/expo.mdx index 8372da47c1aab..cce72f81893bb 100644 --- a/docs/platforms/react-native/sourcemaps/uploading/expo.mdx +++ b/docs/platforms/react-native/sourcemaps/uploading/expo.mdx @@ -17,7 +17,7 @@ Sentry's React Native SDK works out of the box with Expo applications. To see re ## Automatic Upload for Release -When the Sentry Expo Plugin `@sentry/react-native/expo` and the Sentry Metro Pugin are added to your application configuration, source maps for the native builds are uploaded automatically during EAS Builds and when building the native application release locally using `npx expo prebuild`. Note that uploading source maps for debug or simulator builds is disabled, as symbolication is handled by the Metro dev server. +When the Sentry Expo Plugin `@sentry/react-native/expo` and the Sentry Metro Pugin are added to your application configuration, source maps for the native builds are uploaded automatically during EAS Builds and when building the native application release locally using `npx expo prebuild`. Note that uploading source maps for debug builds is disabled, as symbolication is handled by the Metro dev server. ## Manual Upload for EAS Updates From dea687ab8bb7e021ce108b326dda29561ef80111 Mon Sep 17 00:00:00 2001 From: Antonis Lilis Date: Tue, 8 Oct 2024 10:11:39 +0300 Subject: [PATCH 6/7] Update wording of source maps debug builds section Co-authored-by: Liza Mock --- docs/platforms/react-native/sourcemaps/index.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/platforms/react-native/sourcemaps/index.mdx b/docs/platforms/react-native/sourcemaps/index.mdx index 241489f598d8e..646f0c5e19687 100644 --- a/docs/platforms/react-native/sourcemaps/index.mdx +++ b/docs/platforms/react-native/sourcemaps/index.mdx @@ -53,4 +53,4 @@ sentry { ### Debug Builds -Note that automatic uploading of source maps for debug builds is disabled because symbolication is handled directly by the Metro development server. In a development environment, Metro automatically provides the symbolication needed to translate stack traces into readable source code. As a result, there is no need to upload source maps for these types of builds. \ No newline at end of file +Symbolication is handled directly by the Metro development server, automatically providing the symbolication needed to translate stack traces into readable source code in a development environment. There's no need to upload source maps for these types of builds which is why the automatic uploading of source maps is disabled. \ No newline at end of file From 0af17134c91f1e0d6ec81921812fc00c5c41b03a Mon Sep 17 00:00:00 2001 From: Antonis Lilis Date: Tue, 8 Oct 2024 10:12:55 +0300 Subject: [PATCH 7/7] Update wording of debug note on expo section Co-authored-by: Liza Mock --- docs/platforms/react-native/sourcemaps/uploading/expo.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/platforms/react-native/sourcemaps/uploading/expo.mdx b/docs/platforms/react-native/sourcemaps/uploading/expo.mdx index cce72f81893bb..beee8ea36f8a1 100644 --- a/docs/platforms/react-native/sourcemaps/uploading/expo.mdx +++ b/docs/platforms/react-native/sourcemaps/uploading/expo.mdx @@ -17,7 +17,7 @@ Sentry's React Native SDK works out of the box with Expo applications. To see re ## Automatic Upload for Release -When the Sentry Expo Plugin `@sentry/react-native/expo` and the Sentry Metro Pugin are added to your application configuration, source maps for the native builds are uploaded automatically during EAS Builds and when building the native application release locally using `npx expo prebuild`. Note that uploading source maps for debug builds is disabled, as symbolication is handled by the Metro dev server. +When the Sentry Expo Plugin `@sentry/react-native/expo` and the Sentry Metro Plugin are added to your application configuration, source maps for the native builds are uploaded automatically during EAS Builds and when building the native application release locally using `npx expo prebuild`. Because symbolication is already handled by the Metro dev server, automatic uploading of source maps for debug builds is disabled. ## Manual Upload for EAS Updates