-
-
Notifications
You must be signed in to change notification settings - Fork 276
Feat: Sync Scope to Native #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
|
We need to avoid crumbs duplication for iOS, on React Native we have a workaround for Android, See https://github.com/getsentry/sentry-react-native/blob/main/src/js/wrapper.ts#L100-L110 |
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
|
@bruno-garcia @denrase So the main question here is: The other option is to make it fire and forget by default and document as best effort. |
We can either fix it if possible or regenerate the baseline file |
|
@denrase left a few comments but other than that, all good, thanks for doing this. |
|
In |
marandaneto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @denrase
📜 Description
Sync scope to native. This is a breaking change, as some methods of
scope.dartnow return a future which can be awaited on.💡 Motivation and Context
Closes #194
💚 How did you test it?
Unit tests.
📝 Checklist
🔮 Next steps
Check on web wether data is synced correctly to the native layer