From 174f25e68483eb5c6a80874266a4f8e8ed863f62 Mon Sep 17 00:00:00 2001 From: Manoel Aranda Neto Date: Tue, 25 Jan 2022 11:21:47 +0100 Subject: [PATCH 1/3] Fix: captureTransaction should return emptyId when transaction is discarded --- CHANGELOG.md | 2 ++ dart/lib/src/sentry_client.dart | 2 +- dart/test/sentry_client_test.dart | 9 +++++++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 326c337933..1894066588 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,7 @@ # Unreleased +* Fix: captureTransaction should return emptyId when transaction is discarded (#) + # 6.3.0-beta.3 * Feat: Auto transactions duration trimming (#702) diff --git a/dart/lib/src/sentry_client.dart b/dart/lib/src/sentry_client.dart index a976b9b3d7..6e0a870627 100644 --- a/dart/lib/src/sentry_client.dart +++ b/dart/lib/src/sentry_client.dart @@ -261,7 +261,7 @@ class SentryClient { final id = await captureEnvelope( SentryEnvelope.fromTransaction(preparedTransaction, _options.sdk)); - return id!; + return id ?? SentryId.empty(); } /// Reports the [envelope] to Sentry.io. diff --git a/dart/test/sentry_client_test.dart b/dart/test/sentry_client_test.dart index 6a9c6fdf31..a059fa88ba 100644 --- a/dart/test/sentry_client_test.dart +++ b/dart/test/sentry_client_test.dart @@ -346,6 +346,15 @@ void main() { expect(capturedEvent['exception'], isNull); }); + + test('should return empty for when transaction is discarded', () async { + + final client = fixture.getSut(eventProcessor: DropAllEventProcessor()); + final tr = SentryTransaction(fixture.tracer); + final id = await client.captureTransaction(tr); + + expect(id, SentryId.empty()); + }); }); group('SentryClient : apply scope to the captured event', () { From 32aae07c8041a8fb8a59d5ee1b9698bc35e540db Mon Sep 17 00:00:00 2001 From: Manoel Aranda Neto Date: Tue, 25 Jan 2022 11:22:06 +0100 Subject: [PATCH 2/3] pr id --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1894066588..a0009e8cb7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Unreleased -* Fix: captureTransaction should return emptyId when transaction is discarded (#) +* Fix: captureTransaction should return emptyId when transaction is discarded (#713) # 6.3.0-beta.3 From 00ccde1d422259c3b5900dc45c94600d0f7a27da Mon Sep 17 00:00:00 2001 From: Manoel Aranda Neto Date: Tue, 25 Jan 2022 12:55:21 +0100 Subject: [PATCH 3/3] fix format --- dart/test/sentry_client_test.dart | 1 - 1 file changed, 1 deletion(-) diff --git a/dart/test/sentry_client_test.dart b/dart/test/sentry_client_test.dart index a059fa88ba..b6d39958a0 100644 --- a/dart/test/sentry_client_test.dart +++ b/dart/test/sentry_client_test.dart @@ -348,7 +348,6 @@ void main() { }); test('should return empty for when transaction is discarded', () async { - final client = fixture.getSut(eventProcessor: DropAllEventProcessor()); final tr = SentryTransaction(fixture.tracer); final id = await client.captureTransaction(tr);