From 86013ff8b38d1a254fa43579bb299bffcbf2e787 Mon Sep 17 00:00:00 2001 From: Denis Andrasec Date: Tue, 25 Feb 2025 13:32:05 +0100 Subject: [PATCH 1/3] v9: Remove renderer from `flutter_context` --- .../src/event_processor/flutter_enricher_event_processor.dart | 3 --- flutter/lib/src/view_hierarchy/view_hierarchy_integration.dart | 2 +- .../event_processor/flutter_enricher_event_processor_test.dart | 1 - 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/flutter/lib/src/event_processor/flutter_enricher_event_processor.dart b/flutter/lib/src/event_processor/flutter_enricher_event_processor.dart index 1c5a5faba3..f34d7e28f0 100644 --- a/flutter/lib/src/event_processor/flutter_enricher_event_processor.dart +++ b/flutter/lib/src/event_processor/flutter_enricher_event_processor.dart @@ -138,8 +138,6 @@ class FlutterEnricherEventProcessor implements EventProcessor { // ignore: deprecated_member_use final hasRenderView = _widgetsBinding?.renderViewElement != null; - final renderer = _options.rendererWrapper.getRenderer()?.name; - return { 'has_render_view': hasRenderView.toString(), if (tempDebugBrightnessOverride != null) @@ -156,7 +154,6 @@ class FlutterEnricherEventProcessor implements EventProcessor { // Also always fails in tests. // See https://github.com/flutter/flutter/issues/83919 // 'window_is_visible': _window.viewConfiguration.visible, - if (renderer != null) 'renderer': renderer, if (appFlavor != null) 'appFlavor': appFlavor!, }; } diff --git a/flutter/lib/src/view_hierarchy/view_hierarchy_integration.dart b/flutter/lib/src/view_hierarchy/view_hierarchy_integration.dart index a86f380f08..97afeed81a 100644 --- a/flutter/lib/src/view_hierarchy/view_hierarchy_integration.dart +++ b/flutter/lib/src/view_hierarchy/view_hierarchy_integration.dart @@ -1,7 +1,7 @@ import '../../sentry_flutter.dart'; import 'view_hierarchy_event_processor.dart'; -/// A [Integration] that renders an ASCII represention of the entire view +/// A [Integration] that renders an ASCII representation of the entire view /// hierarchy of the application when an error happens and includes it as an /// attachment to the [Hint]. class SentryViewHierarchyIntegration diff --git a/flutter/test/event_processor/flutter_enricher_event_processor_test.dart b/flutter/test/event_processor/flutter_enricher_event_processor_test.dart index 6f82a6e6b2..3a7e7462a2 100644 --- a/flutter/test/event_processor/flutter_enricher_event_processor_test.dart +++ b/flutter/test/event_processor/flutter_enricher_event_processor_test.dart @@ -73,7 +73,6 @@ void main() { final flutterContext = event?.contexts['flutter_context']; expect(flutterContext, isNotNull); expect(flutterContext, isA>()); - expect(flutterContext['renderer'], isNotNull); }); testWidgets('accessibility context', (WidgetTester tester) async { From fc413a591a067bb010228fa2421e746da4e1c8bb Mon Sep 17 00:00:00 2001 From: Denis Andrasec Date: Tue, 25 Feb 2025 13:37:01 +0100 Subject: [PATCH 2/3] add cl entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 63263fec85..c225618b44 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ - Responses are attached to the `Hint` object, which can be read in `beforeSend`/`beforeSendTransaction` callbacks via `hint.response`. - For now, only the `dio` integration is supported. - Enable privacy masking for screenshots by default ([#2728](https://github.com/getsentry/sentry-dart/pull/2728)) +- Remove renderer from `flutter_context` ([#2751](https://github.com/getsentry/sentry-dart/pull/2751)) ### Enhancements From cd489a77e1f962e92e1ea5699b46a5a928deb54e Mon Sep 17 00:00:00 2001 From: Denis Andrasec Date: Mon, 3 Mar 2025 14:46:50 +0100 Subject: [PATCH 3/3] fix cl --- CHANGELOG.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7eccc6abd4..c93f3507f3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,8 +1,9 @@ # Changelog -## 9.0.0 Unreleased +## Unreleased 9.0.0 - Move replay and privacy from experimental to options ([#2755](https://github.com/getsentry/sentry-dart/pull/2755)) +- Remove renderer from `flutter_context` ([#2751](https://github.com/getsentry/sentry-dart/pull/2751)) ## 9.0.0-alpha.1 @@ -27,7 +28,7 @@ - Responses are attached to the `Hint` object, which can be read in `beforeSend`/`beforeSendTransaction` callbacks via `hint.response`. - For now, only the `dio` integration is supported. - Enable privacy masking for screenshots by default ([#2728](https://github.com/getsentry/sentry-dart/pull/2728)) -- Remove renderer from `flutter_context` ([#2751](https://github.com/getsentry/sentry-dart/pull/2751)) + ### Enhancements