Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Feb 10, 2025

📜 Description

💡 Motivation and Context

Closes #2684

💚 How did you test it?

Existing tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.12%. Comparing base (3e1c2c9) to head (a891e72).
Report is 2 commits behind head on v9.

Additional details and impacted files
@@            Coverage Diff             @@
##               v9    #2685      +/-   ##
==========================================
+ Coverage   89.06%   89.12%   +0.05%     
==========================================
  Files         261      261              
  Lines        8847     8842       -5     
==========================================
  Hits         7880     7880              
+ Misses        967      962       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor requested a review from vaind February 11, 2025 10:26
@buenaflor
Copy link
Contributor Author

@vaind hey I saw you added these deprecations a while ago, is this change the way we want it?

@vaind
Copy link
Collaborator

vaind commented Feb 11, 2025

@vaind hey I saw you added these deprecations a while ago, is this change the way we want it?

Looks like I did it because it's useless now? I'd delete it completely if we can, not even leaving it for tests.

@buenaflor
Copy link
Contributor Author

buenaflor commented Feb 11, 2025

@vaind I deleted the dartLogger which was unused but the noOp logger is still used when setting the debug flag and is the default for the options.logger

@buenaflor buenaflor merged commit 98d6f2d into v9 Feb 11, 2025
153 checks passed
@buenaflor buenaflor deleted the v9-task/remove-deprecated-loggers branch February 11, 2025 15:22
@vaind vaind mentioned this pull request Feb 18, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants