-
-
Notifications
You must be signed in to change notification settings - Fork 276
[v9] Remove deprecated loggers #2685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v9 #2685 +/- ##
==========================================
+ Coverage 89.06% 89.12% +0.05%
==========================================
Files 261 261
Lines 8847 8842 -5
==========================================
Hits 7880 7880
+ Misses 967 962 -5 ☔ View full report in Codecov by Sentry. |
|
@vaind hey I saw you added these deprecations a while ago, is this change the way we want it? |
Looks like I did it because it's useless now? I'd delete it completely if we can, not even leaving it for tests. |
|
@vaind I deleted the |
📜 Description
💡 Motivation and Context
Closes #2684
💚 How did you test it?
Existing tests
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps