Skip to content

Conversation

@denrase
Copy link
Collaborator

@denrase denrase commented Jan 29, 2025

📜 Description

  • Bump dart and flutter min versions
  • Remove dynamic casts for unavailable APIs
  • Format

💡 Motivation and Context

Closes #2626

💚 How did you test it?

CI

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

# Conflicts:
#	.github/workflows/dart.yml
#	dart/test/run_zoned_guarded_integration_test.dart
#	flutter/lib/src/sentry_asset_bundle.dart
#	flutter/lib/src/sentry_flutter.dart
#	flutter/test/screenshot/sentry_screenshot_widget_test.dart
@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/lib/src/screenshot/recorder.dart

@denrase denrase marked this pull request as ready for review January 29, 2025 17:38
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good on first pass 👍

will have another look later

Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have another library added now link, you can change the versions there too

@ueman
Copy link
Collaborator

ueman commented Jan 31, 2025

You can also get rid of this compatibility code:

/// Copied from https://api.flutter.dev/flutter/services/appFlavor-constant.html
/// As soon as Flutter 3.16 is the minimal supported version of Sentry, this
/// can be replaced with the property from the link above.
const String? _appFlavor = String.fromEnvironment('FLUTTER_APP_FLAVOR') != ''
? String.fromEnvironment('FLUTTER_APP_FLAVOR')
: null;

@codecov
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.17%. Comparing base (79ccefb) to head (adef8af).
Report is 200 commits behind head on v9.

Files with missing lines Patch % Lines
...nt_processor/flutter_enricher_event_processor.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##               v9    #2643       +/-   ##
===========================================
+ Coverage   67.94%   89.17%   +21.22%     
===========================================
  Files          15      263      +248     
  Lines         443     8924     +8481     
===========================================
+ Hits          301     7958     +7657     
- Misses        142      966      +824     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denrase denrase requested review from buenaflor and ueman and removed request for buenaflor February 3, 2025 13:36
@denrase denrase requested review from buenaflor and vaind February 4, 2025 13:01
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated

## 9.0.0

- Bump Dart and Flutter version, Dart to 3.5.0, Flutter to 3.24.0 ([#2643](https://github.com/getsentry/sentry-dart/pull/2643))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Bump Dart and Flutter version, Dart to 3.5.0, Flutter to 3.24.0 ([#2643](https://github.com/getsentry/sentry-dart/pull/2643))
- Increase minimum SDK version requirements to Dart v3.5.0 and Flutter v3.24.0 ([#2643](https://github.com/getsentry/sentry-dart/pull/2643))

@denrase denrase merged commit 606f16b into v9 Feb 5, 2025
148 of 149 checks passed
@denrase denrase deleted the v9-bump-dart branch February 5, 2025 09:49
@vaind vaind mentioned this pull request Feb 18, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants