Skip to content

fix mask overlay flutter session replay #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 14, 2025
Merged

fix mask overlay flutter session replay #2576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d414f2
fix: change visitChildElements to debugVisitOnstageChildren
thisames Dec 12, 2024
2d34c24
fix: change visitChildElements to debugVisitOnstageChildren
thisames Dec 12, 2024
6b517b6
Merge branch 'fix-mask-overlay-flutter-session-replay' of github.com:…
vaind Jan 13, 2025
651151b
chore:changelog
vaind Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
### Fixes

- Replay: fix masking for frames captured during UI changes ([#2553](https://github.com/getsentry/sentry-dart/pull/2553))
- Replay: fix widget masks overlap when navigating between screens ([#2486](https://github.com/getsentry/sentry-dart/pull/2486), [#2576](https://github.com/getsentry/sentry-dart/pull/2576))

### Dependencies

Expand Down
2 changes: 1 addition & 1 deletion flutter/lib/src/screenshot/widget_filter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class WidgetFilter {
break;
case SentryMaskingDecision.continueProcessing:
// If this element should not be obscured, visit and check its children.
element.visitChildElements(_visitList.add);
element.debugVisitOnstageChildren(_visitList.add);
break;
}
}
Expand Down
Loading