-
-
Notifications
You must be signed in to change notification settings - Fork 276
fix mask overlay flutter session replay #2576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…thisames/sentry-dart into fix-mask-overlay-flutter-session-replay
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2576 +/- ##
==========================================
+ Coverage 87.35% 92.46% +5.10%
==========================================
Files 269 92 -177
Lines 9531 3186 -6345
==========================================
- Hits 8326 2946 -5380
+ Misses 1205 240 -965 ☔ View full report in Codecov by Sentry. |
4b3c01b to
6b517b6
Compare
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a40bb7c | 1222.75 ms | 1240.88 ms | 18.13 ms |
| 6689749 | 1243.66 ms | 1251.94 ms | 8.28 ms |
| 29297d4 | 1245.82 ms | 1276.57 ms | 30.76 ms |
| 72dfc83 | 1262.50 ms | 1289.75 ms | 27.25 ms |
| 89ea268 | 1252.33 ms | 1253.58 ms | 1.26 ms |
| 9d43f71 | 1225.06 ms | 1227.06 ms | 2.00 ms |
| aed5947 | 1268.67 ms | 1281.10 ms | 12.43 ms |
| 8e133ad | 1268.19 ms | 1277.37 ms | 9.18 ms |
| 2261c15 | 1249.49 ms | 1259.69 ms | 10.20 ms |
| dd76eef | 1222.51 ms | 1258.38 ms | 35.87 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a40bb7c | 8.38 MiB | 9.73 MiB | 1.35 MiB |
| 6689749 | 8.38 MiB | 9.78 MiB | 1.40 MiB |
| 29297d4 | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| 72dfc83 | 8.15 MiB | 9.12 MiB | 987.30 KiB |
| 89ea268 | 8.09 MiB | 9.16 MiB | 1.06 MiB |
| 9d43f71 | 8.29 MiB | 9.39 MiB | 1.10 MiB |
| aed5947 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 8e133ad | 8.10 MiB | 9.16 MiB | 1.07 MiB |
| 2261c15 | 8.28 MiB | 9.34 MiB | 1.06 MiB |
| dd76eef | 8.33 MiB | 9.64 MiB | 1.31 MiB |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3de8b9b | 348.55 ms | 445.84 ms | 97.29 ms |
| 6d50a9b | 467.98 ms | 526.48 ms | 58.50 ms |
| 3a16179 | 471.61 ms | 513.45 ms | 41.83 ms |
| ebfead1 | 298.44 ms | 374.28 ms | 75.84 ms |
| f056db1 | 426.04 ms | 475.76 ms | 49.72 ms |
| 2a0edba | 376.12 ms | 454.00 ms | 77.88 ms |
| 256df44 | 447.58 ms | 485.84 ms | 38.25 ms |
| ef31c7f | 311.39 ms | 359.33 ms | 47.94 ms |
| c978477 | 347.00 ms | 409.94 ms | 62.94 ms |
| 3500574 | 288.69 ms | 358.34 ms | 69.65 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3de8b9b | 6.27 MiB | 7.20 MiB | 957.75 KiB |
| 6d50a9b | 6.49 MiB | 7.55 MiB | 1.06 MiB |
| 3a16179 | 6.52 MiB | 7.61 MiB | 1.08 MiB |
| ebfead1 | 6.06 MiB | 7.03 MiB | 989.24 KiB |
| f056db1 | 6.52 MiB | 7.61 MiB | 1.09 MiB |
| 2a0edba | 6.33 MiB | 7.30 MiB | 992.46 KiB |
| 256df44 | 6.52 MiB | 7.59 MiB | 1.06 MiB |
| ef31c7f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| c978477 | 6.33 MiB | 7.29 MiB | 987.32 KiB |
| 3500574 | 6.16 MiB | 7.14 MiB | 1009.90 KiB |
Moved an external contrib to a new PR so that the CI runs
I've tested this manually on iOS and Android