Skip to content

Commit f19679d

Browse files
committed
improve naming
1 parent ca2bc55 commit f19679d

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

dart/lib/src/sentry_baggage.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import 'package:meta/meta.dart';
2-
32
import 'protocol.dart';
43
import 'scope.dart';
54
import 'sentry_options.dart';

dart/lib/src/sentry_traces_sampler.dart

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ class SentryTracesSampler {
3131
final tracesSampler = _options.tracesSampler;
3232
if (tracesSampler != null) {
3333
try {
34-
final result = tracesSampler(samplingContext);
35-
if (result != null) {
36-
return _decideSampling(result);
34+
final sampleRate = tracesSampler(samplingContext);
35+
if (sampleRate != null) {
36+
return _makeSampleDecision(sampleRate);
3737
}
3838
} catch (exception, stackTrace) {
3939
_options.logger(
@@ -61,7 +61,7 @@ class SentryTracesSampler {
6161
double? optionsOrDefaultRate = optionsRate ?? defaultRate;
6262

6363
if (optionsOrDefaultRate != null) {
64-
return _decideSampling(optionsOrDefaultRate);
64+
return _makeSampleDecision(optionsOrDefaultRate);
6565
}
6666

6767
return SentryTracesSamplingDecision(false);
@@ -72,18 +72,17 @@ class SentryTracesSampler {
7272
if (optionsRate == null || !tracesSamplingDecision.sampled) {
7373
return false;
7474
}
75-
return _shouldSample(optionsRate);
75+
return _isSampled(optionsRate);
7676
}
7777

78-
SentryTracesSamplingDecision _decideSampling(double sampleRate) {
78+
SentryTracesSamplingDecision _makeSampleDecision(double sampleRate) {
7979
final sampleRand = _random.nextDouble();
80-
return SentryTracesSamplingDecision(
81-
_shouldSample(sampleRate, sampleRand: sampleRand),
82-
sampleRate: sampleRate,
83-
sampleRand: sampleRand);
80+
final sampled = _isSampled(sampleRate, sampleRand: sampleRand);
81+
return SentryTracesSamplingDecision(sampled,
82+
sampleRate: sampleRate, sampleRand: sampleRand);
8483
}
8584

86-
bool _shouldSample(double sampleRate, {double? sampleRand}) {
85+
bool _isSampled(double sampleRate, {double? sampleRand}) {
8786
final rand = sampleRand ?? _random.nextDouble();
8887
return rand <= sampleRate;
8988
}

0 commit comments

Comments
 (0)