Skip to content

Commit d44ba48

Browse files
authored
deprecate: manual ttid widget (#2477)
* deprecate * update * revert test skip
1 parent dc6fc46 commit d44ba48

File tree

4 files changed

+11
-1
lines changed

4 files changed

+11
-1
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## Unreleased
44

5+
### Deprecate
6+
7+
- Manual TTID ([#2477](https://github.com/getsentry/sentry-dart/pull/2477))
8+
59
### Enhancements
610

711
- Warning (in a debug build) if a potentially sensitive widget is not masked or unmasked explicitly ([#2375](https://github.com/getsentry/sentry-dart/pull/2375))

flutter/example/lib/main.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -781,6 +781,7 @@ void navigateToAutoCloseScreen(BuildContext context) {
781781
context,
782782
MaterialPageRoute(
783783
settings: const RouteSettings(name: 'AutoCloseScreen'),
784+
// ignore: deprecated_member_use
784785
builder: (context) => SentryDisplayWidget(child: const AutoCloseScreen()),
785786
),
786787
);

flutter/lib/src/navigation/sentry_display_widget.dart

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import 'package:flutter/cupertino.dart';
2-
import 'time_to_initial_display_tracker.dart';
32

43
import '../frame_callback_handler.dart';
4+
import 'time_to_initial_display_tracker.dart';
55

66
/// A widget that reports the Time To Initially Displayed (TTID) of its child widget.
77
///
@@ -27,6 +27,9 @@ import '../frame_callback_handler.dart';
2727
/// See also:
2828
/// - [Sentry's documentation on Flutter integrations](https://docs.sentry.io/platforms/flutter/)
2929
/// for more information on how to integrate Sentry into your Flutter application.
30+
@Deprecated(
31+
'Manual TTID tracking is no longer needed - Sentry automatically tracks TTID accurately.'
32+
' You can safely remove this widget.')
3033
class SentryDisplayWidget extends StatefulWidget {
3134
final Widget child;
3235
final FrameCallbackHandler _frameCallbackHandler;
@@ -42,6 +45,7 @@ class SentryDisplayWidget extends StatefulWidget {
4245
_SentryDisplayWidgetState createState() => _SentryDisplayWidgetState();
4346
}
4447

48+
// ignore: deprecated_member_use_from_same_package
4549
class _SentryDisplayWidgetState extends State<SentryDisplayWidget> {
4650
@override
4751
void initState() {

flutter/test/navigation/sentry_display_widget_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ class Fixture {
6969

7070
MaterialApp getSut() {
7171
return MaterialApp(
72+
// ignore: deprecated_member_use_from_same_package
7273
home: SentryDisplayWidget(
7374
frameCallbackHandler: frameCallbackHandler,
7475
child: Text('my text'),

0 commit comments

Comments
 (0)