Merge branch 'feat/feature-flags-integration' into fear/firebase-feature-flags

Author: denrase

CHANGELOG.md

@@ -10,6 +10,14 @@
 Sentry.addFeatureFlag('my-feature', true);
 ```
 
+### Behavioral changes
+
+- Set log level to `warning` by default when `debug = true` ([#2836](https://github.com/getsentry/sentry-dart/pull/2836))
+
+### API Changes
+
+- Update naming of `LoadImagesListIntegration` to `LoadNativeDebugImagesIntegration` ([#2833](https://github.com/getsentry/sentry-dart/pull/2833))
+
 ### Dependencies
 
 - Bump Android SDK from v8.2.0 to v8.6.0 ([#2819](https://github.com/getsentry/sentry-dart/pull/2819), [#2831](https://github.com/getsentry/sentry-dart/pull/2831))
@@ -21,6 +29,15 @@ Sentry.addFeatureFlag('my-feature', true);
 - Bump Native SDK from v0.8.2 to v0.8.3 ([#2823](https://github.com/getsentry/sentry-dart/pull/2823))
   - [changelog](https://github.com/getsentry/sentry-native/blob/master/CHANGELOG.md#083)
   - [diff](https://github.com/getsentry/sentry-native/compare/0.8.2...0.8.3)
+- Bump jni from v0.14.0 to v0.14.1 ([#2800])(https://github.com/getsentry/sentry-dart/pull/2800)
+  - [changelog](https://github.com/dart-lang/native/blob/main/pkgs/jni/CHANGELOG.md#0141)
+  - [diff](https://github.com/dart-lang/native/compare/jnigen-v0.14.0..jnigen-v0.14.1)
+
+### Behavioral changes
+
+- Mutable Data Classes ([#2818](https://github.com/getsentry/sentry-dart/pull/2818))
+  - Some SDK classes do not have `const` constructors anymore.
+  - The `copyWith` and `clone` methods of SDK classes were deprecated.
 
 ## 9.0.0-alpha.2
 
@@ -37,13 +54,13 @@ Sentry.addFeatureFlag('my-feature', true);
 - Bump Javascript SDK from v8.42.0 to v9.5.0 ([#2784](https://github.com/getsentry/sentry-dart/pull/2784))
   - [changelog](https://github.com/getsentry/sentry-javascript/blob/main/CHANGELOG.md#950)
   - [diff](https://github.com/getsentry/sentry-javascript/compare/8.42.0...9.5.0)
- 
+
 ### Behavioral changes
 
 - Set sentry-native backend to `crashpad` by default and `breakpad` for Windows ARM64 ([#2791](https://github.com/getsentry/sentry-dart/pull/2791))
   - Setting the `SENTRY_NATIVE_BACKEND` environment variable will override the defaults.
 - Remove renderer from `flutter_context` ([#2751](https://github.com/getsentry/sentry-dart/pull/2751))
-
+  
 ### API changes
 
 - Move replay and privacy from experimental to options ([#2755](https://github.com/getsentry/sentry-dart/pull/2755))

dart/example/bin/event_example.dart

@@ -29,15 +29,15 @@ final event = SentryEvent(
     )
   ],
   contexts: Contexts(
-    operatingSystem: const SentryOperatingSystem(
+    operatingSystem: SentryOperatingSystem(
       name: 'Android',
       version: '5.0.2',
       build: 'LRX22G.P900XXS0BPL2',
       kernelVersion:
           'Linux version 3.4.39-5726670 (dpi@SWHC3807) (gcc version 4.8 (GCC) ) #1 SMP PREEMPT Thu Dec 1 19:42:39 KST 2016',
       rooted: false,
     ),
-    runtimes: [const SentryRuntime(name: 'ART', version: '5')],
+    runtimes: [SentryRuntime(name: 'ART', version: '5')],
     app: SentryApp(
       name: 'Example Dart App',
       version: '1.42.0',
@@ -47,7 +47,7 @@ final event = SentryEvent(
       deviceAppHash: '5afd3a6',
       startTime: DateTime.now().toUtc(),
     ),
-    browser: const SentryBrowser(name: 'Firefox', version: '42.0.1'),
+    browser: SentryBrowser(name: 'Firefox', version: '42.0.1'),
     device: SentryDevice(
       name: 'SM-P900',
       family: 'SM-P900',

dart/example_web/web/event.dart

@@ -28,15 +28,15 @@ final event = SentryEvent(
     )
   ],
   contexts: Contexts(
-    operatingSystem: const SentryOperatingSystem(
+    operatingSystem: SentryOperatingSystem(
       name: 'Android',
       version: '5.0.2',
       build: 'LRX22G.P900XXS0BPL2',
       kernelVersion:
           'Linux version 3.4.39-5726670 (dpi@SWHC3807) (gcc version 4.8 (GCC) ) #1 SMP PREEMPT Thu Dec 1 19:42:39 KST 2016',
       rooted: false,
     ),
-    runtimes: [const SentryRuntime(name: 'ART', version: '5')],
+    runtimes: [SentryRuntime(name: 'ART', version: '5')],
     app: SentryApp(
       name: 'Example Dart App',
       version: '1.42.0',
@@ -46,7 +46,7 @@ final event = SentryEvent(
       deviceAppHash: '5afd3a6',
       startTime: DateTime.now().toUtc(),
     ),
-    browser: const SentryBrowser(name: 'Firefox', version: '42.0.1'),
+    browser: SentryBrowser(name: 'Firefox', version: '42.0.1'),
     device: SentryDevice(
       name: 'SM-P900',
       family: 'SM-P900',

dart/lib/src/diagnostic_logger.dart

@@ -2,8 +2,9 @@ import 'protocol.dart';
 import 'sentry_options.dart';
 
 class DiagnosticLogger {
-  final SentryLogger _logger;
   final SentryOptions _options;
+  final SentryLogger _logger;
+  SentryLogger get logger => _logger;
 
   DiagnosticLogger(this._logger, this._options);
 

dart/lib/src/event_processor/enricher/flutter_runtime.dart

@@ -17,7 +17,7 @@ const _isFlutterRuntimeInformationAbsent = FlutterVersion.version == null ||
     FlutterVersion.channel == null ||
     FlutterVersion.frameworkRevision == null;
 
-const SentryRuntime? flutterRuntime = _isFlutterRuntimeInformationAbsent
+final SentryRuntime? flutterRuntime = _isFlutterRuntimeInformationAbsent
     ? null
     : SentryRuntime(
         name: 'Flutter',
@@ -28,7 +28,7 @@ const SentryRuntime? flutterRuntime = _isFlutterRuntimeInformationAbsent
             '- Git URL ${FlutterVersion.gitUrl}',
       );
 
-const SentryRuntime? dartFlutterRuntime = FlutterVersion.dartVersion == null
+final SentryRuntime? dartFlutterRuntime = FlutterVersion.dartVersion == null
     ? null
     : SentryRuntime(name: 'Dart', version: FlutterVersion.dartVersion);
 

dart/lib/src/event_processor/enricher/io_enricher_event_processor.dart

@@ -44,18 +44,18 @@ class IoEnricherEventProcessor implements EnricherEventProcessor {
   Future<SentryEvent?> apply(SentryEvent event, Hint hint) async {
     final contexts = event.contexts;
 
-    contexts.device = await _getDevice(event.contexts.device);
-    contexts.operatingSystem =
-        _getOperatingSystem(event.contexts.operatingSystem);
-    contexts.runtimes = _getRuntimes(event.contexts.runtimes);
-    contexts.app = _getApp(event.contexts.app);
-    contexts.culture = _getSentryCulture(event.contexts.culture);
+    contexts
+      ..device = await _getDevice(event.contexts.device)
+      ..operatingSystem = _getOperatingSystem(event.contexts.operatingSystem)
+      ..runtimes = _getRuntimes(event.contexts.runtimes)
+      ..app = _getApp(event.contexts.app)
+      ..culture = _getSentryCulture(event.contexts.culture);
 
     contexts['dart_context'] = _getDartContext();
 
-    return event.copyWith(
-      contexts: contexts,
-    );
+    event.contexts = contexts;
+
+    return event;
   }
 
   List<SentryRuntime> _getRuntimes(List<SentryRuntime>? runtimes) {
@@ -102,13 +102,13 @@ class IoEnricherEventProcessor implements EnricherEventProcessor {
   }
 
   Future<SentryDevice> _getDevice(SentryDevice? device) async {
-    return (device ?? SentryDevice()).copyWith(
-      name: device?.name ??
-          (_options.sendDefaultPii ? Platform.localHostname : null),
-      processorCount: device?.processorCount ?? Platform.numberOfProcessors,
-      memorySize: device?.memorySize ?? await _getTotalPhysicalMemory(),
-      freeMemory: device?.freeMemory,
-    );
+    device ??= SentryDevice();
+    return device
+      ..name = device.name ??
+          (_options.sendDefaultPii ? Platform.localHostname : null)
+      ..processorCount = device.processorCount ?? Platform.numberOfProcessors
+      ..memorySize = device.memorySize ?? await _getTotalPhysicalMemory()
+      ..freeMemory = device.freeMemory;
   }
 
   Future<int?> _getTotalPhysicalMemory() async {
@@ -121,14 +121,22 @@ class IoEnricherEventProcessor implements EnricherEventProcessor {
   }
 
   SentryApp _getApp(SentryApp? app) {
-    return (app ?? SentryApp()).copyWith(
-      appMemory: app?.appMemory ?? ProcessInfo.currentRss,
-    );
+    app ??= SentryApp();
+    return app..appMemory = app.appMemory ?? ProcessInfo.currentRss;
   }
 
   SentryOperatingSystem _getOperatingSystem(SentryOperatingSystem? os) {
     if (os == null) {
-      return _os.clone();
+      return SentryOperatingSystem(
+        name: _os.name,
+        version: _os.version,
+        build: _os.build,
+        kernelVersion: _os.kernelVersion,
+        rooted: _os.rooted,
+        rawDescription: _os.rawDescription,
+        theme: _os.theme,
+        unknown: _os.unknown,
+      );
     } else {
       return _os.mergeWith(os);
     }
@@ -171,10 +179,10 @@ class IoEnricherEventProcessor implements EnricherEventProcessor {
   }
 
   SentryCulture _getSentryCulture(SentryCulture? culture) {
-    return (culture ?? SentryCulture()).copyWith(
-      locale: culture?.locale ?? Platform.localeName,
-      timezone: culture?.timezone ?? DateTime.now().timeZoneName,
-    );
+    culture ??= SentryCulture();
+    return culture
+      ..locale = culture.locale ?? Platform.localeName
+      ..timezone = culture.timezone ?? DateTime.now().timeZoneName;
   }
 }
 

dart/lib/src/event_processor/enricher/web_enricher_event_processor.dart

@@ -24,20 +24,16 @@ class WebEnricherEventProcessor implements EnricherEventProcessor {
   @override
   SentryEvent? apply(SentryEvent event, Hint hint) {
     // Web has no native integration, so no need to check for it
+    event.contexts
+      ..device = _getDevice(event.contexts.device)
+      ..culture = _getSentryCulture(event.contexts.culture)
+      ..runtimes = _getRuntimes(event.contexts.runtimes);
 
-    final contexts = event.contexts.copyWith(
-      device: _getDevice(event.contexts.device),
-      culture: _getSentryCulture(event.contexts.culture),
-      runtimes: _getRuntimes(event.contexts.runtimes),
-    );
+    event.contexts['dart_context'] = _getDartContext();
 
-    contexts['dart_context'] = _getDartContext();
-
-    return event.copyWith(
-      contexts: contexts,
-      request: _getRequest(event.request),
-      transaction: event.transaction ?? _window.location.pathname,
-    );
+    return event
+      ..request = _getRequest(event.request)
+      ..transaction = event.transaction ?? _window.location.pathname;
   }
 
   // As seen in
@@ -51,22 +47,24 @@ class WebEnricherEventProcessor implements EnricherEventProcessor {
     header.putIfAbsent('User-Agent', () => _window.navigator.userAgent);
 
     final url = request?.url ?? _window.location.toString();
-    return (request ?? SentryRequest(url: url))
-        .copyWith(headers: header)
-        .sanitized();
+    request ??= SentryRequest(url: url);
+    return request
+      ..headers = header
+      ..sanitize();
   }
 
   SentryDevice _getDevice(SentryDevice? device) {
-    return (device ?? SentryDevice()).copyWith(
-      online: device?.online ?? _window.navigator.onLine,
-      memorySize: device?.memorySize ?? _getMemorySize(),
-      orientation: device?.orientation ?? _getScreenOrientation(),
-      screenHeightPixels:
-          device?.screenHeightPixels ?? _window.screen.availHeight,
-      screenWidthPixels: device?.screenWidthPixels ?? _window.screen.availWidth,
-      screenDensity:
-          device?.screenDensity ?? _window.devicePixelRatio.toDouble(),
-    );
+    device ??= SentryDevice();
+    return device
+      ..online = device.online ?? _window.navigator.onLine
+      ..memorySize = device.memorySize ?? _getMemorySize()
+      ..orientation = device.orientation ?? _getScreenOrientation()
+      ..screenHeightPixels =
+          device.screenHeightPixels ?? _window.screen.availHeight
+      ..screenWidthPixels =
+          device.screenWidthPixels ?? _window.screen.availWidth
+      ..screenDensity =
+          device.screenDensity ?? _window.devicePixelRatio.toDouble();
   }
 
   int? _getMemorySize() {
@@ -96,9 +94,8 @@ class WebEnricherEventProcessor implements EnricherEventProcessor {
   }
 
   SentryCulture _getSentryCulture(SentryCulture? culture) {
-    return (culture ?? SentryCulture()).copyWith(
-      timezone: culture?.timezone ?? DateTime.now().timeZoneName,
-    );
+    culture ??= SentryCulture();
+    return culture..timezone = culture.timezone ?? DateTime.now().timeZoneName;
   }
 
   List<SentryRuntime> _getRuntimes(List<SentryRuntime>? runtimes) {

dart/lib/src/event_processor/exception/io_exception_event_processor.dart

@@ -35,9 +35,7 @@ class IoExceptionEventProcessor implements ExceptionEventProcessor {
     if (uri == null) {
       return event;
     }
-    return event.copyWith(
-      request: event.request ?? SentryRequest.fromUri(uri: uri),
-    );
+    return event..request = event.request ?? SentryRequest.fromUri(uri: uri);
   }
 
   // https://api.dart.dev/stable/dart-io/SocketException-class.html
@@ -48,15 +46,14 @@ class IoExceptionEventProcessor implements ExceptionEventProcessor {
     final address = exception.address;
     final osError = exception.osError;
     if (address == null) {
-      return event.copyWith(
-        exceptions: [
-          // OSError is the underlying error
-          // https://api.dart.dev/stable/dart-io/SocketException/osError.html
-          // https://api.dart.dev/stable/dart-io/OSError-class.html
-          if (osError != null) _sentryExceptionfromOsError(osError),
-          ...?event.exceptions,
-        ],
-      );
+      event.exceptions = [
+        // OSError is the underlying error
+        // https://api.dart.dev/stable/dart-io/SocketException/osError.html
+        // https://api.dart.dev/stable/dart-io/OSError-class.html
+        if (osError != null) _sentryExceptionfromOsError(osError),
+        ...?event.exceptions,
+      ];
+      return event;
     }
     SentryRequest? request;
     try {
@@ -74,16 +71,15 @@ class IoExceptionEventProcessor implements ExceptionEventProcessor {
       }
     }
 
-    return event.copyWith(
-      request: event.request ?? request,
-      exceptions: [
-        // OSError is the underlying error
-        // https://api.dart.dev/stable/dart-io/SocketException/osError.html
-        // https://api.dart.dev/stable/dart-io/OSError-class.html
-        if (osError != null) _sentryExceptionfromOsError(osError),
-        ...?event.exceptions,
-      ],
-    );
+    event.request = event.request ?? request;
+    event.exceptions = [
+      // OSError is the underlying error
+      // https://api.dart.dev/stable/dart-io/SocketException/osError.html
+      // https://api.dart.dev/stable/dart-io/OSError-class.html
+      if (osError != null) _sentryExceptionfromOsError(osError),
+      ...?event.exceptions,
+    ];
+    return event;
   }
 
   // https://api.dart.dev/stable/dart-io/FileSystemException-class.html
@@ -92,15 +88,14 @@ class IoExceptionEventProcessor implements ExceptionEventProcessor {
     SentryEvent event,
   ) {
     final osError = exception.osError;
-    return event.copyWith(
-      exceptions: [
-        // OSError is the underlying error
-        // https://api.dart.dev/stable/dart-io/FileSystemException/osError.html
-        // https://api.dart.dev/stable/dart-io/OSError-class.html
-        if (osError != null) _sentryExceptionfromOsError(osError),
-        ...?event.exceptions,
-      ],
-    );
+    event.exceptions = [
+      // OSError is the underlying error
+      // https://api.dart.dev/stable/dart-io/FileSystemException/osError.html
+      // https://api.dart.dev/stable/dart-io/OSError-class.html
+      if (osError != null) _sentryExceptionfromOsError(osError),
+      ...?event.exceptions,
+    ];
+    return event;
   }
 }
 

dart/lib/src/feature_flags_integration.dart

@@ -33,9 +33,9 @@ class FeatureFlagsIntegration extends Integration<SentryOptions> {
       values.add(SentryFeatureFlag(name: name, value: value));
     }
 
-    final newFlags = flags.copyWith(values: values);
+    flags.values = values;
 
-    await _hub?.scope.setContexts(SentryFeatureFlags.type, newFlags);
+    await _hub?.scope.setContexts(SentryFeatureFlags.type, flags);
   }
 
   @override