Auto Transactions (#643)

Author: denrase

CHANGELOG.md

@@ -1,5 +1,6 @@
 # Unreleased
 
+* Feat: Automatically create transactions when navigating between screens (#643)
 # 6.2.2
 
 * Fix: ConcurrentModificationError in when finishing span (#664)

dart/lib/src/hub.dart

@@ -3,7 +3,6 @@ import 'dart:collection';
 
 import 'package:meta/meta.dart';
 
-import 'noop_sentry_span.dart';
 import 'protocol.dart';
 import 'scope.dart';
 import 'sentry_client.dart';
@@ -340,6 +339,8 @@ class Hub {
     String operation, {
     String? description,
     bool? bindToScope,
+    bool? waitForChildren,
+    Duration? autoFinishAfter,
     Map<String, dynamic>? customSamplingContext,
   }) =>
       startTransactionWithContext(
@@ -349,6 +350,8 @@ class Hub {
           description: description,
         ),
         bindToScope: bindToScope,
+        waitForChildren: waitForChildren,
+        autoFinishAfter: autoFinishAfter,
         customSamplingContext: customSamplingContext,
       );
 
@@ -357,6 +360,8 @@ class Hub {
     SentryTransactionContext transactionContext, {
     Map<String, dynamic>? customSamplingContext,
     bool? bindToScope,
+    bool? waitForChildren,
+    Duration? autoFinishAfter,
   }) {
     if (!_isEnabled) {
       _options.logger(
@@ -380,8 +385,12 @@ class Hub {
         transactionContext = transactionContext.copyWith(sampled: sampled);
       }
 
-      final tracer = SentryTracer(transactionContext, this);
-
+      final tracer = SentryTracer(
+        transactionContext,
+        this,
+        waitForChildren: waitForChildren ?? false,
+        autoFinishAfter: autoFinishAfter,
+      );
       if (bindToScope ?? false) {
         item.scope.span = tracer;
       }

dart/lib/src/hub_adapter.dart

@@ -102,11 +102,15 @@ class HubAdapter implements Hub {
     SentryTransactionContext transactionContext, {
     Map<String, dynamic>? customSamplingContext,
     bool? bindToScope,
+    bool? waitForChildren,
+    Duration? autoFinishAfter,
   }) =>
       Sentry.startTransactionWithContext(
         transactionContext,
         customSamplingContext: customSamplingContext,
         bindToScope: bindToScope,
+        waitForChildren: waitForChildren,
+        autoFinishAfter: autoFinishAfter,
       );
 
   @override
@@ -115,13 +119,17 @@ class HubAdapter implements Hub {
     String operation, {
     String? description,
     bool? bindToScope,
+    bool? waitForChildren,
+    Duration? autoFinishAfter,
     Map<String, dynamic>? customSamplingContext,
   }) =>
       Sentry.startTransaction(
         name,
         operation,
         description: description,
         bindToScope: bindToScope,
+        waitForChildren: waitForChildren,
+        autoFinishAfter: autoFinishAfter,
         customSamplingContext: customSamplingContext,
       );
 

dart/lib/src/noop_hub.dart

@@ -4,7 +4,6 @@ import 'protocol.dart';
 import 'sentry_client.dart';
 import 'sentry_user_feedback.dart';
 import 'tracing.dart';
-import 'noop_sentry_span.dart';
 
 class NoOpHub implements Hub {
   NoOpHub._();
@@ -79,6 +78,8 @@ class NoOpHub implements Hub {
     String operation, {
     String? description,
     bool? bindToScope,
+    bool? waitForChildren,
+    Duration? autoFinishAfter,
     Map<String, dynamic>? customSamplingContext,
   }) =>
       NoOpSentrySpan();
@@ -88,6 +89,8 @@ class NoOpHub implements Hub {
     SentryTransactionContext transactionContext, {
     Map<String, dynamic>? customSamplingContext,
     bool? bindToScope,
+    bool? waitForChildren,
+    Duration? autoFinishAfter,
   }) =>
       NoOpSentrySpan();
 

dart/lib/src/protocol/breadcrumb.dart

@@ -1,7 +1,6 @@
 import 'package:meta/meta.dart';
 
 import '../utils.dart';
-import 'sentry_level.dart';
 import '../protocol.dart';
 
 /// Structed data to describe more information pior to the event captured.

dart/lib/src/protocol/sentry_span.dart

@@ -1,3 +1,5 @@
+import 'dart:async';
+
 import '../hub.dart';
 import '../protocol.dart';
 
@@ -17,6 +19,7 @@ class SentrySpan extends ISentrySpan {
 
   SpanStatus? _status;
   final Map<String, String> _tags = {};
+  void Function()? _finishedCallback;
 
   @override
   bool? sampled;
@@ -26,8 +29,10 @@ class SentrySpan extends ISentrySpan {
     this._context,
     this._hub, {
     bool? sampled,
+    Function()? finishedCallback,
   }) {
     this.sampled = sampled;
+    _finishedCallback = finishedCallback;
   }
 
   @override
@@ -45,6 +50,8 @@ class SentrySpan extends ISentrySpan {
     if (_throwable != null) {
       _hub.setSpanContext(_throwable, this, _tracer.name);
     }
+    _finishedCallback?.call();
+    await super.finish(status: status);
   }
 
   @override

dart/lib/src/protocol/sentry_transaction.dart

@@ -2,7 +2,6 @@ import 'package:meta/meta.dart';
 
 import '../protocol.dart';
 import '../sentry_tracer.dart';
-import 'sentry_span.dart';
 import '../utils.dart';
 
 @immutable

dart/lib/src/sentry.dart

@@ -229,13 +229,17 @@ class Sentry {
     String operation, {
     String? description,
     bool? bindToScope,
+    bool? waitForChildren,
+    Duration? autoFinishAfter,
     Map<String, dynamic>? customSamplingContext,
   }) =>
       _hub.startTransaction(
         name,
         operation,
         description: description,
         bindToScope: bindToScope,
+        waitForChildren: waitForChildren,
+        autoFinishAfter: autoFinishAfter,
         customSamplingContext: customSamplingContext,
       );
 
@@ -244,11 +248,15 @@ class Sentry {
     SentryTransactionContext transactionContext, {
     Map<String, dynamic>? customSamplingContext,
     bool? bindToScope,
+    bool? waitForChildren,
+    Duration? autoFinishAfter,
   }) =>
       _hub.startTransactionWithContext(
         transactionContext,
         customSamplingContext: customSamplingContext,
         bindToScope: bindToScope,
+        waitForChildren: waitForChildren,
+        autoFinishAfter: autoFinishAfter,
       );
 
   /// Gets the current active transaction or span.

dart/lib/src/sentry_envelope.dart

@@ -6,8 +6,6 @@ import 'utils.dart';
 import 'sentry_attachment/sentry_attachment.dart';
 import 'sentry_envelope_header.dart';
 import 'sentry_envelope_item.dart';
-import 'protocol/sentry_event.dart';
-import 'protocol/sdk_version.dart';
 import 'sentry_user_feedback.dart';
 
 /// Class representation of `Envelope` file.

dart/lib/src/sentry_envelope_item.dart

@@ -3,7 +3,6 @@ import 'protocol.dart';
 import 'utils.dart';
 import 'sentry_attachment/sentry_attachment.dart';
 import 'sentry_item_type.dart';
-import 'protocol/sentry_event.dart';
 import 'sentry_envelope_item_header.dart';
 import 'sentry_user_feedback.dart';