From c0ff5aa3e3118494cbe4733d975fc99fbbe8598d Mon Sep 17 00:00:00 2001
From: Maciej Walkowiak <walkowiak.maciej@yahoo.com>
Date: Fri, 4 Sep 2020 11:40:19 +0200
Subject: [PATCH] Extract minimum required coverage by Jacoco plugin.

---
 buildSrc/src/main/java/Config.kt            | 6 ++++++
 sentry-core/build.gradle.kts                | 5 ++---
 sentry-log4j2/build.gradle.kts              | 4 ++--
 sentry-logback/build.gradle.kts             | 4 ++--
 sentry-spring-boot-starter/build.gradle.kts | 4 ++--
 5 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/buildSrc/src/main/java/Config.kt b/buildSrc/src/main/java/Config.kt
index 9246dbb3d..5b2d0f833 100644
--- a/buildSrc/src/main/java/Config.kt
+++ b/buildSrc/src/main/java/Config.kt
@@ -1,3 +1,5 @@
+import java.math.BigDecimal
+
 object Config {
     val kotlinVersion = "1.3.72"
     val kotlinStdLib = "stdlib-jdk8"
@@ -72,6 +74,10 @@ object Config {
     }
 
     object QualityPlugins {
+        object Jacoco {
+            val version = "0.8.5"
+            val minimumCoverage = BigDecimal.valueOf(0.6)
+        }
         val jacocoVersion = "0.8.5"
         val spotless = "com.diffplug.spotless"
         val spotlessVersion = "5.1.0"
diff --git a/sentry-core/build.gradle.kts b/sentry-core/build.gradle.kts
index 58bb6468a..389a41d48 100644
--- a/sentry-core/build.gradle.kts
+++ b/sentry-core/build.gradle.kts
@@ -43,7 +43,7 @@ configure<SourceSetContainer> {
 }
 
 jacoco {
-    toolVersion = Config.QualityPlugins.jacocoVersion
+    toolVersion = Config.QualityPlugins.Jacoco.version
 }
 
 tasks.jacocoTestReport {
@@ -56,8 +56,7 @@ tasks.jacocoTestReport {
 tasks {
     jacocoTestCoverageVerification {
         violationRules {
-            // TODO: Raise the minimum to a sensible value.
-            rule { limit { minimum = BigDecimal.valueOf(0.1) } }
+            rule { limit { minimum = Config.QualityPlugins.Jacoco.minimumCoverage } }
         }
     }
     check {
diff --git a/sentry-log4j2/build.gradle.kts b/sentry-log4j2/build.gradle.kts
index f2c4408c7..65f45d222 100644
--- a/sentry-log4j2/build.gradle.kts
+++ b/sentry-log4j2/build.gradle.kts
@@ -44,7 +44,7 @@ configure<SourceSetContainer> {
 }
 
 jacoco {
-    toolVersion = Config.QualityPlugins.jacocoVersion
+    toolVersion = Config.QualityPlugins.Jacoco.version
 }
 
 tasks.jacocoTestReport {
@@ -57,7 +57,7 @@ tasks.jacocoTestReport {
 tasks {
     jacocoTestCoverageVerification {
         violationRules {
-            rule { limit { minimum = BigDecimal.valueOf(0.6) } }
+            rule { limit { minimum = Config.QualityPlugins.Jacoco.minimumCoverage } }
         }
     }
     check {
diff --git a/sentry-logback/build.gradle.kts b/sentry-logback/build.gradle.kts
index 7b42bdd29..92e6c6926 100644
--- a/sentry-logback/build.gradle.kts
+++ b/sentry-logback/build.gradle.kts
@@ -43,7 +43,7 @@ configure<SourceSetContainer> {
 }
 
 jacoco {
-    toolVersion = Config.QualityPlugins.jacocoVersion
+    toolVersion = Config.QualityPlugins.Jacoco.version
 }
 
 tasks.jacocoTestReport {
@@ -56,7 +56,7 @@ tasks.jacocoTestReport {
 tasks {
     jacocoTestCoverageVerification {
         violationRules {
-            rule { limit { minimum = BigDecimal.valueOf(0.6) } }
+            rule { limit { minimum = Config.QualityPlugins.Jacoco.minimumCoverage } }
         }
     }
     check {
diff --git a/sentry-spring-boot-starter/build.gradle.kts b/sentry-spring-boot-starter/build.gradle.kts
index 100ea7aee..24e556c71 100644
--- a/sentry-spring-boot-starter/build.gradle.kts
+++ b/sentry-spring-boot-starter/build.gradle.kts
@@ -63,7 +63,7 @@ configure<SourceSetContainer> {
 }
 
 jacoco {
-    toolVersion = Config.QualityPlugins.jacocoVersion
+    toolVersion = Config.QualityPlugins.Jacoco.version
 }
 
 tasks.jacocoTestReport {
@@ -76,7 +76,7 @@ tasks.jacocoTestReport {
 tasks {
     jacocoTestCoverageVerification {
         violationRules {
-            rule { limit { minimum = BigDecimal.valueOf(0.6) } }
+            rule { limit { minimum = Config.QualityPlugins.Jacoco.minimumCoverage } }
         }
     }
     check {