Rename flag to --skip-user-creation (#1696)

Author: chadwhitacre

install/parse-cli.sh

@@ -16,20 +16,32 @@ Options:
                           upgrades.
  --skip-commit-check    Skip the check for the latest commit when on the master
                           branch of a \`self-hosted\` Git working copy.
- --skip-user-prompt     Skip the initial user creation prompt (ideal for non-
+ --skip-user-creation   Skip the initial user creation prompt (ideal for non-
                           interactive installs).
 EOF
 }
 
-SKIP_USER_PROMPT="${SKIP_USER_PROMPT:-}"
+depwarn() {
+  echo "WARNING The $1 is deprecated. Please use $2 instead."
+}
+
+if [ ! -z "${SKIP_USER_PROMPT:-}" ]; then
+  depwarn "SKIP_USER_PROMPT variable" "SKIP_USER_CREATION"
+  SKIP_USER_CREATION="${SKIP_USER_PROMPT}"
+fi
+
+SKIP_USER_CREATION="${SKIP_USER_CREATION:-}"
 MINIMIZE_DOWNTIME="${MINIMIZE_DOWNTIME:-}"
 SKIP_COMMIT_CHECK="${SKIP_COMMIT_CHECK:-}"
 
 while (( $# )); do
   case "$1" in
     -h | --help) show_help; exit;;
-    --no-user-prompt) SKIP_USER_PROMPT=1;;  # deprecated
-    --skip-user-prompt) SKIP_USER_PROMPT=1;;
+    --no-user-prompt) SKIP_USER_CREATION=1;
+      depwarn "--no-user-prompt flag" "--skip-user-creation";;
+    --skip-user-prompt) SKIP_USER_CREATION=1;
+      depwarn "--skip-user-prompt flag" "--skip-user-creation";;
+    --skip-user-creation) SKIP_USER_CREATION=1;;
     --minimize-downtime) MINIMIZE_DOWNTIME=1;;
     --skip-commit-check) SKIP_COMMIT_CHECK=1;;
     --) ;;

install/set-up-and-migrate-database.sh

@@ -1,10 +1,10 @@
 echo "${_group}Setting up / migrating database ..."
 
-if [[ -n "${CI:-}" || "${SKIP_USER_PROMPT:-0}" == 1 ]]; then
+if [[ -n "${CI:-}" || "${SKIP_USER_CREATION:-0}" == 1 ]]; then
   $dcr web upgrade --noinput
   echo ""
-  echo "Did not prompt for user creation due to non-interactive shell."
-  echo "Run the following command to create one yourself (recommended):"
+  echo "Did not prompt for user creation. Run the following command to create one"
+  echo "yourself (recommended):"
   echo ""
   echo "  $dc_base run --rm web createuser"
   echo ""