This repository was archived by the owner on Aug 14, 2024. It is now read-only.
feat(event): Add source to SDK payload #815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AbhiPrasad
force-pushed
the
abhi-sdk-source
branch
from
c1ab40a to
596abdd
Compare
This was referenced Jan 19, 2023
Member
Author
|
FYI folks I'm reverting this #819 This is because we can probably just the the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
sourcefield to the SDK interface that is part of the event payload.We can use this source field to list the installation source of the SDK. For most cases this will be a package repository like
npmorpypi, but it can also be things likecdn.Current uses cases:
Browser Web:
npmcdnloaderApple:
spmcarthagecocoapods