Improve self-hosted docs about installation behind the proxy #628
Conversation
|
@goganchic is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
aminvakil
left a comment
aminvakil
left a comment
There was a problem hiding this comment.
Thank you for keeping to improve docs!
| "httpProxy": "http://proxy:3128", | ||
| "httpsProxy": "http://proxy:3128", | ||
| "noProxy": "127.0.0.0/8" | ||
| "noProxy": "relay,web,sentry,127.0.0.0/8" |
There was a problem hiding this comment.
Have you tested a clean working installation with these variables? Are these enough? We have kafka:9092 in relay/config.yml for example, shouldn't we also add kafka to noProxy?
There was a problem hiding this comment.
I'd removed all docker containers, images, volumes and networks and reinstalled Sentry one more time, checked web, created test event. I'd found no errors in docker logs.
There was a problem hiding this comment.
Please wait a bit, I need to recheck it one more time.
There was a problem hiding this comment.
From the one hand proxies from ~/.docker/config.json work only for docker run command and do not work for docker build. It is written in the docker docs:
When you create or start new containers, the environment variables are set automatically within the container.
From the other hand we need a connection to the Internet only during build stage. So we do not need ~/.docker/config.json at all. We need to set correct env variables through /etc/environment and that's it. In this commit getsentry/self-hosted@2672ce5 we do not need changes in /etc/apt/apt.conf, because all required variables will be passed through /etc/environment.
Sorry for my mistake.
There was a problem hiding this comment.
@aminvakil I'd updated PR, please take a look.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Catching up on the threads ... what's our status here? getsentry/self-hosted#1560 is closed, do we still want to remove step (4) of the docs with this PR? |
|
Yes. Before getsentry/self-hosted#1560 I thought that step 1 is redundant, but actually it's required and step 4 is not. |
|
Actually, step 4 is required if you want to send daily stats to sentry.io with |
|
I had the same thought. Not everyone will care to do that but it would be good to note in a comment, yes. Thanks! :) |
|
@chadwhitacre I've added the information about the configuration access for Sentry Beacon. |
chadwhitacre
left a comment
chadwhitacre
left a comment
There was a problem hiding this comment.
Thanks for the attention to detail, @goganchic!
aminvakil
left a comment
aminvakil
left a comment
There was a problem hiding this comment.
LGTM!
@goganchic Thanks for improving docs!
3 participants
necessary code changes: getsentry/self-hosted#1560