Skip to content

Commit d4b5da6

Browse files
authored
Updating action to use node20 (#80)
* Updating action to use node20 * Updating README * Updating workflow
1 parent 86b9938 commit d4b5da6

File tree

6 files changed

+167
-173
lines changed

6 files changed

+167
-173
lines changed

.github/workflows/test.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,12 @@ jobs:
66
build: # make sure build/ci work properly
77
runs-on: ubuntu-latest
88
steps:
9-
- uses: actions/checkout@v2
9+
- uses: actions/checkout@v4
1010

11-
- uses: actions/setup-node@v2
11+
- uses: actions/setup-node@v4
1212
with:
1313
cache: yarn
14+
node-version: 20
1415

1516
- run: yarn
1617

@@ -30,7 +31,7 @@ jobs:
3031
private_key: ${{ secrets.INTEGRATION_TEST_APP_PRIVATE_KEY }}
3132

3233
- name: Integration test - checkout private repo
33-
uses: actions/checkout@v2
34+
uses: actions/checkout@v4
3435
with:
3536
repository: getsentry/action-github-app-token-test
3637
token: ${{ steps.my-app.outputs.token }}

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ You will need to provide the GitHub App ID and private key. The action will then
2222
```
2323
- name: my-app-install token
2424
id: my-app
25-
uses: getsentry/action-github-app-token@v2
25+
uses: getsentry/action-github-app-token@v3
2626
with:
2727
app_id: ${{ secrets.APP_ID }}
2828
private_key: ${{ secrets.APP_PRIVATE_KEY }}
2929
3030
- name: Checkout private repo
31-
uses: actions/checkout@v2
31+
uses: actions/checkout@v4
3232
with:
3333
repository: getsentry/my-private-repo
3434
token: ${{ steps.my-app.outputs.token }}

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@ outputs:
1616
token:
1717
description: 'Github Token for App installation'
1818
runs:
19-
using: 'node16'
19+
using: 'node20'
2020
main: 'dist/index.js'

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,15 @@
4545
"node-fetch": "^2.6.1"
4646
},
4747
"dependencies": {
48-
"@actions/core": "^1.10.0",
49-
"@octokit/auth-app": "^4.0.7",
50-
"@octokit/rest": "^19.0.5"
48+
"@actions/core": "^1.10.1",
49+
"@octokit/auth-app": "^6.0.3",
50+
"@octokit/rest": "^20.0.2"
5151
},
5252
"devDependencies": {
5353
"@types/jest": "^27.0.1",
5454
"@types/node": "^12.7.12",
5555
"@typescript-eslint/parser": "^4.30.0",
56-
"@vercel/ncc": "^0.34.0",
56+
"@vercel/ncc": "^0.38.1",
5757
"eslint": "^7.32.0",
5858
"eslint-config-sentry": "^1.60.0",
5959
"eslint-plugin-github": "^4.2.0",

src/main.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@ async function run(): Promise<void> {
2525
let installationId = installations.data[0].id;
2626
if (scope !== '') {
2727
const scopedData = installations.data.find(
28-
(item) => item.account?.login === scope
28+
(item) =>
29+
item.account &&
30+
'login' in item.account &&
31+
item.account?.login === scope
2932
);
3033
if (scopedData === undefined) {
3134
throw new Error(`set scope is ${scope}, but installation is not found`);

0 commit comments

Comments
 (0)