This repository was archived by the owner on Jan 20, 2025. It is now read-only.
issue #207 「リスト」と「一覧」を「一覧」に統一する #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add expect and pattern rules in prh.yml to correct orthographic variants in issues207.
To do with issues 207, convert "リスト" to "一覧" at once.
chanrute
requested review from
Naturalclar,
hirotaka,
smorimoto and
uetchy
as code owners
Closed
smorimoto
added
the
status: awaiting review
smorimoto
reviewed
Mar 7, 2020
smorimoto
reviewed
Mar 7, 2020
smorimoto
added
status: awaiting author response
Unnecessary conversion was corrected. And change rule setting method in prh.yml.
Contributor
Author
|
@imbsky |
Contributor
|
@f-teruhisa 修正ありがとうございます。今回は良いので、次回からサジェストをコミットする際は #202 (comment) にあるようにしてください。 |
smorimoto
added
status: awaiting review
Contributor
Author
|
ありがとうございます。了解しました。 |
Contributor
|
Closes #207 |
Naturalclar
added
status: awaiting more approval
uetchy
approved these changes
Mar 8, 2020
uetchy
added
status: ready to merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
prh.ymlにルールを追加したチェックリスト
textlintを使って校正を行いました。Allow edits from maintainersにチェックを入れました。補足
以前、#100 で翻訳Contributeを行わせていただきました。
少し時間が空いたので、翻訳の方もお手伝いしたかったのですが、承認をいただくまでに時間がかかりそうだったので、issuesの対応をさせて頂きました（不要な対応であれば削除頂いてもかまいません）。
Ref: #207