This repository was archived by the owner on Jan 20, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 113
translate contributing/contributor-swag #173
Merged
uetchy
merged 3 commits into
gatsbyjs:master
from
taka-take:contributing/contributor-swag
Feb 15, 2020
Merged
translate contributing/contributor-swag #173
uetchy
merged 3 commits into
gatsbyjs:master
from
taka-take:contributing/contributor-swag
Feb 15, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirotaka
reviewed
Feb 14, 2020
Contributor
hirotaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!訳は読みやすかったです。
他のドキュメントとの整合性の面でいくつかSuggestionしたのでご確認お願いいたします。
Co-Authored-By: Hirotaka Mizutani <[email protected]>
Contributor
Author
|
レビューありがとうございます! |
Naturalclar
reviewed
Feb 15, 2020
Naturalclar
suggested changes
Feb 15, 2020
Contributor
Naturalclar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
良いと思います!一つだけSuggestしましたので確認お願いします。
Co-Authored-By: Jesse Katsumata <[email protected]>
Contributor
Author
|
レビューありがとうございます! |
Naturalclar
approved these changes
Feb 15, 2020
Contributor
Naturalclar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!LGTM!
uetchy
approved these changes
Feb 15, 2020
38 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
https://www.gatsbyjs.org/contributing/contributor-swag/ の日本語翻訳対応しました。
レビューのほどよろしくお願いします!
チェックリスト
textlintを使って校正を行いました。Allow edits from maintainersにチェックを入れました。補足
以下の 2 箇所の判断に少し迷いました。
Level 2 swagとTier 1 swag、Tier 2 swagをレベルで統一しました。If you’ve contributed in other ways,から始まる文章を分割しました。Ref: #1