Merge task lib 4.x to master (microsoft#903)

* Migrating to Node 16 (microsoft#844)

* create new release/4.x branch

* release for 4 version

* update pipeline

* update package.json

* fix test and build commands

* fixed tests on node18

* change image version for linux

* fix test for linux

* add separete test for linux

* node v16.13

* add v16.13.0 to test

* test on windows-2022, macOS-11

* separate branch for node16

* remove temporary code

* update package.json

* changed pipeline

* updated pipeline

* Microsoft mandatory file (microsoft#839)

* Update pipeline to include a step for publishing artifacts. (microsoft#848) (microsoft#849)

* Update pipeline

* Update azure-pipelines.yml

* nodeversion as variable

* Added node16 to schema (microsoft#852)

Co-authored-by: Andrey Ivanov <[email protected]>

* bump version (microsoft#862)

Co-authored-by: Andrey Ivanov <[email protected]>

* Update ci-cd for publishing npm package (microsoft#863)

* fix npm publish

Co-authored-by: Andrey Ivanov <[email protected]>

* fix add registry (microsoft#864)

Co-authored-by: Andrey Ivanov <[email protected]>

* fix ToolRunner - _getSpawnSyncOptions (microsoft#873)

* Mockery version is updated from 1.7.0 to 2.1.0 because of vulnerability (microsoft#878)

* Fixed release path (microsoft#888)

* Improvement of the release condition (microsoft#889)

* Added test task with test condition. Negative test

* Added test task with test condition. Positive test

* Fix path

* Fix path

* Fix path

* Changed build.sourcebranchname -> build.sourcebranch and path to branch

* Fix path

* Version changed (microsoft#894)

* Pipeline fixing (microsoft#893)

* Token test

* Test token

* Publish test

* call order changed

* Nmp token syntax reverted

* Changed windows job

* Script clearing

* Uncommented condition

* Token changed

* Test - off publish condition

* Switched on publish condition

* Package version was reverted

* Add escape for more correct working

* Add changelog

* Update package-lock version

* Bump tl version to 4.1.0

* Update changelog

* Remove PS task lib changes from node changelog

* Update changelog for 4.0.1-preview

Co-authored-by: AndreyIvanov42 <[email protected]>
Co-authored-by: Andrey Ivanov <[email protected]>
Co-authored-by: Denis Rumyantsev <[email protected]>
Co-authored-by: Roman-Shchukin <[email protected]>

Author: 5 people

CONTRIBUTING.md

@@ -38,4 +38,5 @@ Your pull request should:
     * At least one test should fail in the absence of your non-test code changes. If your PR does not match this criteria, please specify why
     * Tests should include reasonable permutations of the target fix/change
     * Include baseline changes with your change
-    * All changed code must have 100% code coverage
+    * All changed code must have 100% code coverage
+

azure-pipelines.yml

@@ -4,10 +4,10 @@ trigger:
 - releases/*
 
 variables:
-- group: npm-tokens
-- name: nodeVersion
-  value: '10.23.0'
-  
+  - group: npm-tokens
+  - name: nodeVersion
+    value: '16.13.0'
+
 jobs:
 #################################################
 - job: windows
@@ -17,11 +17,12 @@ jobs:
     vmImage: windows-2019
 
   steps:
-  - template: azure-pipelines-steps-node.yml
-    parameters:
-      nodeVersion: $(nodeVersion)
-  - template: azure-pipelines-steps-test-build.yml
-  
+    - template: azure-pipelines-steps-node.yml
+      parameters:
+        nodeVersion: $(nodeVersion)
+
+    - template: azure-pipelines-steps-test-build.yml
+
 #################################################
 - job: linux
 #################################################
@@ -59,7 +60,8 @@ jobs:
     vmImage: macOS-10.15
 
   steps:
-  - template: azure-pipelines-steps-node.yml
-    parameters:
-      nodeVersion: $(nodeVersion)
-  - template: azure-pipelines-steps-test-build.yml
+    - template: azure-pipelines-steps-node.yml
+      parameters:
+        nodeVersion: $(nodeVersion)
+
+    - template: azure-pipelines-steps-test-build.yml

node/CHANGELOG.md

@@ -0,0 +1,34 @@
+# Node.js task lib changes
+
+## 3.x
+
+### 3.3.1
+
+- Update minimatch to version 3.0.5 to fix vulnerability - [#836](https://github.com/microsoft/azure-pipelines-task-lib/pull/836)
+
+### 3.4.0
+
+- Updated mockery and mocha dependencies - [#875](https://github.com/microsoft/azure-pipelines-task-lib/pull/875)
+
+- Include uncought exceptions stack trace to the output logs - [#895](https://github.com/microsoft/azure-pipelines-task-lib/pull/895)
+
+## 4.x
+
+### 4.0.0-preview
+
+- Introduced support for node 16 task handler - [#844](https://github.com/microsoft/azure-pipelines-task-lib/pull/844)
+
+### 4.0.1-preview
+
+- Added node16 to task.schema.json - [#852](https://github.com/microsoft/azure-pipelines-task-lib/pull/852)
+- fix ToolRunner - _getSpawnSyncOptions - [#873](https://github.com/microsoft/azure-pipelines-task-lib/pull/873)
+
+### 4.0.2
+
+- Updated mockery because of vulnerabilities - [#878](https://github.com/microsoft/azure-pipelines-task-lib/pull/878)
+
+## 4.1.0
+
+Backported from ver.`3.4.0`:
+
+- Include uncought exceptions stack trace to the output logs - [#895](https://github.com/microsoft/azure-pipelines-task-lib/pull/895)

node/buildutils.js

@@ -35,7 +35,7 @@ exports.getExternals = function () {
     // and add node to the PATH
     var nodeUrl = process.env['TASK_NODE_URL'] || 'https://nodejs.org/dist';
     nodeUrl = nodeUrl.replace(/\/$/, '');  // ensure there is no trailing slash on the base URL
-    var nodeVersion = 'v10.23.0';
+    var nodeVersion = 'v16.13.0';
     switch (platform) {
         case 'darwin':
             var nodeArchivePath = downloadArchive(nodeUrl + '/' + nodeVersion + '/node-' + nodeVersion + '-darwin-x64.tar.gz');

node/mock-test.ts

@@ -143,20 +143,17 @@ export class MockTestRunner {
 
         let downloadVersion: string;
         switch (version) {
-            case 5:
-                downloadVersion = 'v5.10.1';
-                break;
             case 6:
                 downloadVersion = 'v6.17.1';
                 break;
             case 10:
                 downloadVersion = 'v10.21.0';
                 break;
-            case 14:
-                downloadVersion = 'v14.11.0';
+            case 16:
+                downloadVersion = 'v16.13.0';
                 break;
             default:
-                throw new Error('Invalid node version, must be 5, 6, 10, or 14 (received ' + version + ')');
+                throw new Error('Invalid node version, must be 6, 10, or 16 (received ' + version + ')');
         }
 
         // Install node in home directory if it isn't already there.
@@ -170,12 +167,12 @@ export class MockTestRunner {
         }
     }
 
-    // Determines the correct version of node to use based on the contents of the task's task.json. Defaults to Node 14.
+    // Determines the correct version of node to use based on the contents of the task's task.json. Defaults to Node 16.
     private getNodeVersion(): number {
         const taskJsonPath: string = this.getTaskJsonPath();
         if (!taskJsonPath) {
-            console.warn('Unable to find task.json, defaulting to use Node 14');
-            return 10;
+            console.warn('Unable to find task.json, defaulting to use Node 16');
+            return 16;
         }
         const taskJsonContents = fs.readFileSync(taskJsonPath, { encoding: 'utf-8' });
         const taskJson: object = JSON.parse(taskJsonContents);
@@ -188,9 +185,9 @@ export class MockTestRunner {
         );
         const keys = Object.keys(execution);
         for (let i = 0; i < keys.length; i++) {
-            if (keys[i].toLowerCase() == 'node14') {
-                // Prefer node 14 and return immediately.
-                return 14;
+            if (keys[i].toLowerCase() == 'node16') {
+                // Prefer node 16 and return immediately.
+                return 16;
             } else if (keys[i].toLowerCase() == 'node10') {
                 // Prefer node 10 and return immediately.
                 return 10;
@@ -200,8 +197,8 @@ export class MockTestRunner {
         }
 
         if (!nodeVersionFound) {
-            console.warn('Unable to determine execution type from task.json, defaulting to use Node 10');
-            return 10;
+            console.warn('Unable to determine execution type from task.json, defaulting to use Node 16');
+            return 16;
         }
 
         return 6;

node/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "azure-pipelines-task-lib",
-  "version": "3.4.0",
+  "version": "4.1.0",
   "description": "Azure Pipelines Task SDK",
   "main": "./task.js",
   "typings": "./task.d.ts",
@@ -37,13 +37,13 @@
   },
   "devDependencies": {
     "@types/minimatch": "3.0.3",
-    "@types/mocha": "^5.2.7",
+    "@types/mocha": "^9.1.1",
     "@types/mockery": "^1.4.29",
-    "@types/node": "^10.17.0",
+    "@types/node": "^16.11.39",
     "@types/q": "^1.5.4",
     "@types/semver": "^7.3.4",
     "@types/shelljs": "^0.8.8",
-    "mocha": "9.2.2",
+    "mocha": "^9.2.2",
     "typescript": "^4.0.0"
   }
 }