'xlsx' output foemat

Author: fugerit79

.github/workflows/build_maven_package.yml

@@ -63,7 +63,7 @@ jobs:
           # SonarCloud access token should be generated from https://sonarcloud.io/account/security/
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
       - name: Build and analyze
-        run: mvn -B clean install org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -P coverage,full,metadata,sonarfugerit -DgithubParam1=%TEST_GITHUB_USER% -DgithubParam2=%TEST_GITHUB_PASS%
+        run: mvn -B clean install org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -P coverage,full,metadata,sonarfugerit
         env:
           # Needed to get some information about the pull request, if any
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- 'xlsx' output foemat (simple specify xlsx extension for file path)
+
 ## [1.0.0] - 2024-02-19
 
 ### Changed

src/main/java/org/fugerit/java/github/issue/export/GithubIssueExport.java

@@ -24,6 +24,7 @@
 import org.apache.poi.ss.usermodel.CellStyle;
 import org.apache.poi.ss.usermodel.Sheet;
 import org.apache.poi.ss.usermodel.Workbook;
+import org.apache.poi.xssf.usermodel.XSSFWorkbook;
 import org.fugerit.java.core.cfg.ConfigException;
 import org.fugerit.java.core.cli.ArgUtils;
 import org.fugerit.java.core.function.SafeFunction;
@@ -327,20 +328,20 @@ public static Object buildModel( String data, Class c ) throws JsonProcessingExc
 		objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
 		return objectMapper.readValue( data , c );
 	}
-	
-	public static String getValue( Object val ) {
-		String res = null;
-		if ( val != null ) {
-			res = String.valueOf( val );
+
+	private static Workbook createReport( String fileName ) {
+		if ( fileName.toLowerCase().endsWith( "xlsx" ) ) {
+			return new XSSFWorkbook();
+		} else {
+			return new HSSFWorkbook();
 		}
-		return res;
 	}
-	
+
 	private static void handleExcel( GithubIssueInfo info, List<List<String>> lines ) {
 		SafeFunction.apply( () -> {
 			String xlsFile = info.getProperty( ARG_XLSFILE );
 			try ( FileOutputStream fos = new FileOutputStream( new File( xlsFile ) );
-					Workbook workbook = new HSSFWorkbook() ) {
+					Workbook workbook = createReport( xlsFile ) ) {
 				Sheet sheet = workbook.createSheet( "Report github issue" );
 				CellStyle headerStyle = PoiHelper.getHeaderStyle( workbook );
 				String lang = info.getProperty( ARG_LANG );

src/main/java/org/fugerit/java/github/issue/export/helper/PoiHelper.java

@@ -20,6 +20,11 @@ public class PoiHelper {
 
 	private PoiHelper() {}
 
+	/*
+	 * https://support.microsoft.com/en-gb/office/excel-specifications-and-limits-1672b34d-7043-467e-8e27-269d656771c3
+	 */
+	public static final int MAX_XLS_CELL_LENGTH = 32767;
+	
 	/*
 	 * Use with caution, bad performance
 	 */
@@ -41,18 +46,20 @@ public static CellStyle getHeaderStyle( Workbook workbook ) {
 		return style;
 	}
 
+	public static String prepareCell( String currentCell ) {
+		if ( "null".equalsIgnoreCase( currentCell ) ) {
+			currentCell = "";
+		} else if ( currentCell.length() > MAX_XLS_CELL_LENGTH ) {
+			currentCell = currentCell.substring( 0, 32000 )+"[...]";
+		}
+		return currentCell;
+	}
+	
 	public static void addRow( String[] values, int index, Sheet sheet, CellStyle style) {
 		Row row = sheet.createRow( index );
 		for ( int k=0; k<values.length; k++ ) {
 			Cell cell = row.createCell( k );
-			String currentCell = values[k];
-			if ( currentCell.length() > 32767 ) {
-				currentCell = currentCell.substring( 0, 32000 )+" [...]";
-			}
-			if ( currentCell == null || "null".equalsIgnoreCase( currentCell ) ) {
-				currentCell = "";
-			}
-			cell.setCellValue( currentCell );
+			cell.setCellValue( prepareCell( values[k] ) );
 			if ( style != null ) {
 				cell.setCellStyle( style );	
 			}

src/test/java/test/org/fugerit/java/github/issue/export/TestFormatHelper.java

@@ -0,0 +1,21 @@
+package test.org.fugerit.java.github.issue.export;
+
+import java.sql.Date;
+import java.text.ParseException;
+import java.util.Locale;
+
+import org.fugerit.java.github.issue.export.helper.FormatHelper;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TestFormatHelper {
+
+	@Test
+	public void testDate() throws ParseException {
+		String checkDate = "2024-01-01";
+		String checkDateRes = "01/01/2024 00:00";
+		String fd = FormatHelper.formatDate( Date.valueOf( checkDate ) , Locale.ENGLISH.getLanguage() );
+		Assert.assertEquals( checkDateRes , fd);
+	}
+	
+}

src/test/java/test/org/fugerit/java/github/issue/export/TestGithubIssueExportMain.java

@@ -61,6 +61,22 @@ public void testCommandLineAlt() {
 		GithubIssueExportMain.main(args);
 		Assert.assertTrue( outputFile.exists() );
 	}
+
+	@Test
+	public void testCommandLineAltXlsx() {
+		File outputFile = new File( "target", "report.xlsx" );
+		List<String> params = new ArrayList<>(
+				Arrays.asList( ArgUtils.getArgString( GithubIssueExportMain.ARG_GUI ), BooleanUtils.BOOLEAN_FALSE,
+						ArgUtils.getArgString( GithubIssueExport.ARG_OWNER ), "fugerit-org",
+						ArgUtils.getArgString( GithubIssueExport.ARG_REPO ), "github-issue-export",
+						ArgUtils.getArgString( GithubIssueExport.ARG_XLSFILE ), outputFile.getAbsolutePath(),
+						ArgUtils.getArgString( GithubIssueExportMain.ARG_COPY_RES ), "target" )
+		);
+		this.checkUser(params);
+		String[] args = params.toArray( new String[0] );
+		GithubIssueExportMain.main(args);
+		Assert.assertTrue( outputFile.exists() );
+	}
 
 	@Test
 	public void testHel() {

src/test/java/test/org/fugerit/java/github/issue/export/TestPoiHelper.java

@@ -0,0 +1,24 @@
+package test.org.fugerit.java.github.issue.export;
+
+import org.fugerit.java.github.issue.export.helper.PoiHelper;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TestPoiHelper {
+
+	private static final String PAD = "ABCDEFGHABCDEFGHABCDEFGHABCDEFGHABCDEFGHABCDEFGHABCDEFGHABCDEFGHABCDEFGHABCDEFGHABCDEFGH ";
+	
+	@Test
+	public void testPrepareCell() {
+		StringBuffer buffer = new StringBuffer();
+		int length = 0;
+		while ( length < PoiHelper.MAX_XLS_CELL_LENGTH ) {
+			buffer.append( PAD );
+			length+= PAD.length();
+		}
+		String currentCell = PoiHelper.prepareCell( buffer.toString() );
+		Assert.assertTrue( currentCell.indexOf( "[...]" ) > 0 );
+		Assert.assertEquals( "" ,  PoiHelper.prepareCell( "null" ) );
+	}
+	
+}