Pass sign kwargs to generate_signed_url (#460)

jonashaag · web-flow · commit f4b3b8651b79 · 2022-03-25T09:01:57.000-04:00
diff --git a/gcsfs/core.py b/gcsfs/core.py
@@ -1228,7 +1228,7 @@ def sign(self, path, expiration=100, **kwargs):
         )
         bucket = client.bucket(bucket)
         blob = bucket.blob(key)
-        return blob.generate_signed_url(expiration=expiration)
+        return blob.generate_signed_url(expiration=expiration, **kwargs)
 
 
 GoogleCredentials.load_tokens()

Original file line number	Diff line number	Diff line change
`@@ -1228,7 +1228,7 @@ def sign(self, path, expiration=100, **kwargs):`
`1228`	`1228`	`)`
`1229`	`1229`	`bucket = client.bucket(bucket)`
`1230`	`1230`	`blob = bucket.blob(key)`
`1231`		`- return blob.generate_signed_url(expiration=expiration)`
	`1231`	`+ return blob.generate_signed_url(expiration=expiration, **kwargs)`
`1232`	`1232`
`1233`	`1233`
`1234`	`1234`	`GoogleCredentials.load_tokens()`