Allow reading version number from file #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LKedward
approved these changes
Jun 21, 2021
Member
LKedward
left a comment
LKedward
left a comment
There was a problem hiding this comment.
Cheers, this is a useful addition.
I was thinking this could be good for fpm, where the version information is currently in two different places, but I'd probably prefer to have the version string made available to the compiler preprocessor as a definition to avoid having to locate the version file at runtime. But we haven't really looked into preprocessor defines yet for fpm.
These changes here are quite straightforward and are in line with other build systems, so LGTM.
milancurcic
approved these changes
Jun 23, 2021
Member
milancurcic
left a comment
milancurcic
left a comment
There was a problem hiding this comment.
Nice addition, thank you. I left one suggestion.
Co-authored-by: Milan Curcic <[email protected]>
Member
|
With two approvals I'll now merge. Thanks @awvwgk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some projects don't store the version number in the build files but in a separate file. This allows to have central place for all tools to retrieve the version number from rather than multiple redundant version number entries.
.VERSIONfile is used in json-fortran and is parsed in CMake here.