Give Programs Access to Code in Subdirectories #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Sorry about the noisy change set. My editor is set to automatically remove trailing whitespace. |
awvwgk
reviewed
Mar 23, 2021
milancurcic
approved these changes
Mar 23, 2021
LKedward
approved these changes
Mar 24, 2021
Member
LKedward
left a comment
LKedward
left a comment
There was a problem hiding this comment.
Many thanks. This all looks good to me. My only request is are you able to add a failing test for a program using a module in a parent directory, to cover all conditions.
Co-authored-by: Laurence Kedward <[email protected]>
Member
Author
|
I've added the test and updated the doc string as suggested. Thanks for the great reviews guys. I'll give you guys a few hours in case you want to double check the changes and merge later today. |
awvwgk
approved these changes
Mar 27, 2021
everythingfunctional
deleted the
allow-programs-access-to-subdirectories
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Programs can now use modules in subdirectories from their location. I.e. a program
app/main.f90can use a moduleapp/sub_dir/mod.f90. This applies to tests and examples as well.Fix #408